fix(android): Remove unneeded ABIs included #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Breaks NDK builds to have 64-bit libs present
kattrali
force-pushed
the
kattrali/fix-extra-abi
branch
2 times, most recently
from
2898713
to
dccf598
Compare
kattrali
force-pushed
the
kattrali/fix-extra-abi
branch
from
e96a925
to
bf8967a
Compare
Both artifacts don't need to be tested for everything. Remove steps which are unneeded based on either automation or later steps.
kattrali
force-pushed
the
kattrali/fix-extra-abi
branch
from
bf8967a
to
87697c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, including 64-bit libs on Android will break usability on 64-bit Android devices. This change removes them by default, but also packages a second release artifact with all ABIs included for unusual cases.