Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PLAT-5041] Capture device id from Cocoa notifier #203

Merged
merged 3 commits into from
Oct 2, 2020
Merged

[PLAT-5041] Capture device id from Cocoa notifier #203

merged 3 commits into from
Oct 2, 2020

Conversation

nickdowell
Copy link
Contributor

@nickdowell nickdowell commented Sep 25, 2020 •
edited

Goal

Adds "id" to the "device" section of the report for events and sessions.

See PLAT-5041

Testing

Tested manually by building and running example project in Unity.

Verified that id was received and displayed on the dashboard;

Screenshot 2020-09-28 at 14 12 12

https://app.bugsnag.com/bugsnag-test-projects/nick-unity/errors/5f71debdb03083001728e70c?filters%5Bevent.since%5D%5B%5D=30d&filters%5Berror.status%5D%5B%5D=open&event_id=5f71e101005e0380c8160000

@nickdowell nickdowell changed the title 5041 cocoa device [PLAT-5041] Capture device id from Cocoa notifier Sep 25, 2020
@nickdowell nickdowell marked this pull request as draft September 25, 2020 15:07
@nickdowell nickdowell marked this pull request as ready for review September 28, 2020 13:16
tomlongridge
tomlongridge approved these changes Oct 2, 2020
View reviewed changes
Copy link
Contributor

@tomlongridge tomlongridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a changelog entry to cover the device ID and the Cocoa bump, but this can be added in the release PR.

@nickdowell nickdowell merged commit 33474cd into next Oct 2, 2020
@nickdowell nickdowell deleted the 5041-cocoa-device-id branch October 2, 2020 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomlongridge tomlongridge tomlongridge approved these changes

@kattrali kattrali Awaiting requested review from kattrali

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nickdowell @tomlongridge