PLAT-12012 fix for incorrect ios device metadata #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build size impact
Generated by 🚫 Danger |
tomlongridge
approved these changes
Apr 18, 2024
Comment on lines
+775
to
+779
| if (device.jailbroken) { | ||
| [deviceDictionary setObject:@"true" forKey:@"jailbroken"]; | ||
| } else { | ||
| [deviceDictionary setObject:@"false" forKey:@"jailbroken"]; | ||
| } |
There was a problem hiding this comment.
Small nit (not mandatory): the ternary you used for app.isLaunching seems a cleaner way to represent this.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The changes made in the native cocoa notifier broke the method that collects native device metadata.
Testing
Added smoke tests for android and iOS that will let us know in future if the native connection is broken.