Ste #46 - Showing success image if it is available

build-canaries · Jan 22, 2015 · 822a2c4 · 822a2c4
1 parent f5d6f26
commit 822a2c4
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 4 deletions.
diff --git a/src/js/monitor/appender.js b/src/js/monitor/appender.js
@@ -7,7 +7,7 @@ module.exports = function (config, projects) {
             projects.forEach(addBuildStatusToScreen)
 
             if (projects.length === 0) {
-                showSuccessMessage(projects, config);
+                showSuccessMessage(projects, config)
             }
         }
     }
@@ -20,7 +20,17 @@ function addBuildStatusToScreen(project) {
 }
 
 function showSuccessMessage(projects, config) {
-    var successMessage = config.load().successText
-    $('#projects')
-        .append('<li><div class=monitor-outerContainer><div class=monitor-innerContainer>' + successMessage + '</div></div></li>')
+    var settings = config.load()
+    var successImageUrl = settings.successImageUrl
+
+    if (successImageUrl) {
+        $('#projects')
+            .append('<li><div class=monitor-outerContainer><div class=monitor-innerContainer>' +
+            '<img id="success-image" src="'+ successImageUrl +'" />' +
+            '</div></div></li>')
+    } else {
+        var successMessage = settings.successText
+        $('#projects')
+            .append('<li><div class=monitor-outerContainer><div id="success-text" class=monitor-innerContainer>' + successMessage + '</div></div></li>')
+    }
 }
diff --git a/test/js/monitor/appenderTest.js b/test/js/monitor/appenderTest.js
@@ -0,0 +1,21 @@
+var $ = require('jquery')
+var config = {
+    load: function () {
+        return {successText: 'some success text', successImageUrl: 'some-success-url'}
+    }
+}
+var projects = [];
+var appender = require('../../../src/js/monitor/appender')(config, projects)
+
+describe('Showing success message', function () {
+    it('shows success image', function () {
+        $('body').empty()
+        $('body').append('<div id="projects"/>')
+
+        appender.addProjects()
+
+        var successImageUrl = $('#success-image').attr('src');
+        expect(successImageUrl).toBe('some-success-url')
+        expect($('#success-text')).not.toBeInDOM()
+    })
+})