Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @testing-library/react #357

Closed
GentlemanHal opened this issue Jun 2, 2023 · 0 comments
Closed

Update @testing-library/react #357

GentlemanHal opened this issue Jun 2, 2023 · 0 comments
Labels
dependencies Pull requests that update a dependency file for developers Changes that make development easier

Comments

@GentlemanHal
Copy link
Member

GentlemanHal commented Jun 2, 2023

Updating to @testing-library/react v14 caused hundreds of act() warnings.

After some investigation it seems the issue was a mismatch between the @testing-library/dom versions.
@testing-library/cypress requires v8.x but @testing-library/react now requires v9.x.

Going to be honest, not entirely sure how npm dependency resolution works, but we didn't get any warnings for conflicting packages and we ended up with v8.x in our node_modules. This didn't stop @testing-library/react from working, but it seems like this mismatch is what was causing the act() warnings.

For now I've downgraded back to v13.x of @testing-library/react which has removed all the warnings.

I think the simplest thing to do is wait until @testing-library/cypress is updated to also use v9.x of @testing-library/dom.

Useful links:

@GentlemanHal GentlemanHal added for developers Changes that make development easier dependencies Pull requests that update a dependency file labels Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file for developers Changes that make development easier
Projects
Status: Done
Development

No branches or pull requests

1 participant