Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] msvc-runtime #69

Closed
gmh5225 opened this issue Oct 8, 2022 · 1 comment · Fixed by #70
Closed

[bug] msvc-runtime #69

gmh5225 opened this issue Oct 8, 2022 · 1 comment · Fixed by #70

Comments

@gmh5225
Copy link
Contributor

gmh5225 commented Oct 8, 2022

In fact, target.static-runtime is still a dynamic runtime
image

[project]
name = "msvc-runtime"
description = "Static MSVC runtime"
msvc-runtime = "static"

# This target will compile with a static runtime 
[target.static-runtime]
type = "executable"
sources = ["src/main.cpp"]

# This target overrides the [project].msvc-runtime
[target.dynamic-runtime]
type = "executable"
sources = ["src/main.cpp"]
msvc-runtime = "dynamic"

The following is ok

[project]
name = "msvc-runtime"
description = "Static MSVC runtime"
msvc-runtime = "static"

# This target will compile with a static runtime 
[target.static-runtime]
type = "executable"
sources = ["src/main.cpp"]
msvc-runtime = "static"

# This target overrides the [project].msvc-runtime
[target.dynamic-runtime]
type = "executable"
sources = ["src/main.cpp"]
msvc-runtime = "dynamic"

But it's clear that it doesn't match the original meaning of the code

@gmh5225
Copy link
Contributor Author

gmh5225 commented Oct 8, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant