-
-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Github Action to update Ockam Command Manual #4650
Comments
Happy to take a crack at this! I've always wanted to learn github actions, and helping keeping docs up to date is an awesome way to do so 😸 |
@andrewpollack thank you!! for spending time on it. |
Thank you @mrinalwadhwa! I wanted to get your thoughts on best practices for a potential cross-repo workflow. I'm thinking of:
Does this seem like the correct approach? If so, is there an access token I can depend on between the two repositories? |
I am interested in collaborating with someone on their project so I can learn the language while they get a sidekick. |
@mrinalwadhwa Are you able to give any feedback on #4650 (comment) ? Thank you! |
@andrewpollack ah I seem to have completely missed your comment. Sorry about that.
This makes sense 👍
Repository Dispatch triggers across repos are hard to execute safely/securely. We've instead, in similar situations, preferred to execute workflow dispatch from commands run on dev machines. There are some examples to do this in our release scripts here, for example: ockam/tools/scripts/release/release.sh Line 155 in 011cb9c
So, as a start, create the workflow. Let's land that PR and then as part of our release shell script we can invoke the workflow. @metaclips may have advice on where in the release script we could add a trigger to create a pull request that would update the manual. Thank you for spending time on this issue. Sorry again for missing your questions earlier. |
@andrewpollack Thank you for taking the time to look at this issue. Since you’ve not had a chance we’re opening the issue up for other contributors. |
I'd like to help. I'll make a GH workflow on the ockam-documentation repo hat runs the build.sh script and creates a branch with the updated documentation. |
@petersooley That's awesome, this is all yours. Please let us know if you have any questions as you explore. You can also ask questions on the contributors discord https://discord.gg/RAbjRr3kds Also, please associate your PR and issue using this technique: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue |
Hi @mrinalwadhwa |
Hi @mrinalwadhwa I tried to solve this issue. Can you please have a look at it? |
Current
Command Manual lives here
https://github.com/build-trust/ockam-documentation/tree/command
And it can be generated using this shell script
https://github.com/build-trust/ockam-documentation/blob/command/manual/template/mdbook/build.sh
Once generated it gets published here
https://command.ockam.io/manual/
Currently all of this done manually
Desired
A github actions workflow that would trigger as part of our release pipeline and result in creating a pull request to the ockam-documentation repo
We love helping new contributors! ❤️
If you have questions or need help as you explore, please join us on Discord. If you're looking for other issues to contribute to, please checkout our good first issues.
The text was updated successfully, but these errors were encountered: