Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(rust): fix clippy warnings on test code #4462

Merged
merged 2 commits into from
Mar 15, 2023
Merged

refactor(rust): fix clippy warnings on test code #4462

merged 2 commits into from
Mar 15, 2023

Conversation

adrianbenavides
Copy link
Member

@adrianbenavides adrianbenavides requested a review from a team as a code owner March 15, 2023 05:58
@adrianbenavides adrianbenavides force-pushed the adrian/clippy-fixes-on-test-code branch from 4b6697a to 427aaec Compare March 15, 2023 10:28
etorreborre
etorreborre previously approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@etorreborre etorreborre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

davide-baldo
davide-baldo previously approved these changes Mar 15, 2023
View reviewed changes
@davide-baldo
Copy link
Member

@adrianbenavides 👍
How did you run Clippy checks on tests?

@metaclips metaclips dismissed stale reviews from davide-baldo and etorreborre via 8ec6750 March 15, 2023 12:55
@adrianbenavides
Copy link
Member Author

@adrianbenavides 👍 How did you run Clippy checks on tests?

You can either use --all-targets to check everything or --tests to check only the test code.

@metaclips metaclips added this pull request to the merge queue Mar 15, 2023
Merged via the queue into develop with commit 3c71e31 Mar 15, 2023
@metaclips metaclips deleted the adrian/clippy-fixes-on-test-code branch March 15, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davide-baldo davide-baldo davide-baldo approved these changes

@etorreborre etorreborre etorreborre left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adrianbenavides @davide-baldo @etorreborre @metaclips