Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(app): rename the port field into address and support change the address and the port #5893

Closed

Conversation

0x61nas
Copy link
Contributor

@0x61nas 0x61nas commented Sep 4, 2023

Sorry for the late PR, I had to take some time to parse the project structure tree.

Current behavior

The Share a service window only allows the user to define the service port and the address it always defaults to 127.0.0.1

Proposed changes

  • Replace the Port field name to Address
  • We should support the formats Host:Port, IP:Port and Port (defaulting to 127.0.0.1)
  • Adapt the app backend to parse the address correctly.

Checks

…the address and the port

The changes include:
* Replace the Port field name to Address
* We should support the formats Host:Port, IP:Port and Port (defaulting to 127.0.0.1)
* Adapt the app backend to parse the address correctly.
@0x61nas 0x61nas requested a review from a team as a code owner September 4, 2023 21:39
@0x61nas
Copy link
Contributor Author

0x61nas commented Sep 4, 2023

I don't know why the commits are un-signed. I suppose that I've messed up my gitconfig. anyway, I will fix that and open a new PR.

@0x61nas 0x61nas closed this Sep 4, 2023
@0x61nas 0x61nas deleted the feat/configurable-address branch September 4, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In the Share a service window, the Port should be renamed to Address and support such format
1 participant