Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In the Share a service window, the Port should be renamed to Address and support such format #5685

Closed
Tracked by #5683
adrianbenavides opened this issue Aug 21, 2023 · 3 comments · Fixed by #5894
Closed
Tracked by #5683

In the Share a service window, the Port should be renamed to Address and support such format #5685

adrianbenavides opened this issue Aug 21, 2023 · 3 comments · Fixed by #5894
Assignees
@adrianbenavides @0x61nas
Labels
Component: App good first issue help wanted Implementation: Rust

Comments

@adrianbenavides
Copy link
Member

adrianbenavides commented Aug 21, 2023 •
edited

Current

The Share a service window only allows the user to define the service port.

image

Desired

The user should be able to define the whole address. To achieve that, we need to:

  • Replace the Port field name to Address
  • We should support the formats Host:Port, IP:Port and Port (defaulting to 127.0.0.1)
  • Adapt the app backend to parse the address correctly.

We love helping new contributors!
If you have questions or need help as you work on your first Ockam contribution, please leave a comment on this discussion.
If you're looking for other issues to contribute to, checkout this discussion and labels - good first issue or help wanted

@adrianbenavides adrianbenavides mentioned this issue Aug 21, 2023
Closed
3 tasks
@adrianbenavides adrianbenavides changed the title The “Port” should also include “Host:Port” or “IP:Port” in a single text field In the Share a service window, the Port should be renamed to Address and support such format Aug 21, 2023
@0x61nas
Copy link
Contributor

0x61nas commented Sep 1, 2023

The user should be able to define the whole address.

so you want to rename it and make it contain both of address and port in this format ADDRESS:PORT, did I get it right?

@etorreborre
Copy link
Member

@0x61nas yes and PORT only. And in that case we set ADDRESS=127.0.0.1

@0x61nas
Copy link
Contributor

0x61nas commented Sep 1, 2023

cool, in this case, I think that I can work on this, Please assign this issue to me if you don't mind

@adrianbenavides adrianbenavides self-assigned this Sep 4, 2023
@0x61nas 0x61nas mentioned this issue Sep 4, 2023
Closed
4 tasks
0x61nas added a commit to anas-contribs/ockam that referenced this issue Sep 4, 2023
@0x61nas
refactor(app): rename the port field into address and support change …
66e3c29 
…the address and the port

The changes include:
* Replace the Port field name to Address
* We should support the formats Host:Port, IP:Port and Port (defaulting to 127.0.0.1)
* Adapt the app backend to parse the address correctly.

- Closes: build-trust#5685
@0x61nas 0x61nas mentioned this issue Sep 4, 2023
Merged
4 tasks
0x61nas added a commit to anas-contribs/ockam that referenced this issue Sep 5, 2023
@0x61nas
refactor(app): rename the port field into address and support change …
f400554 
…the address and the port

The changes include:
* Replace the Port field name to Address
* We should support the formats Host:Port, IP:Port and Port (defaulting to 127.0.0.1)
* Adapt the app backend to parse the address correctly.

- Closes: build-trust#5685
0x61nas added a commit to anas-contribs/ockam that referenced this issue Sep 5, 2023
@0x61nas
refactor(rust): rename the port field into address and support change…
cd1002b 
… the address and the port

The changes include:
* Replace the Port field name to Address
* We should support the formats Host:Port, IP:Port and Port (defaulting to 127.0.0.1)
* Adapt the app backend to parse the address correctly.

- Closes: build-trust#5685
0x61nas added a commit to anas-contribs/ockam that referenced this issue Sep 6, 2023
@0x61nas
refactor(rust): rename the port field into address and support change…
7adb614 
… the address and the port

The changes include:
* Replace the Port field name to Address
* We should support the formats Host:Port, IP:Port and Port (defaulting to 127.0.0.1)
* Adapt the app backend to parse the address correctly.

- Closes: build-trust#5685
0x61nas added a commit to anas-contribs/ockam that referenced this issue Sep 6, 2023
@0x61nas
refactor(rust): rename the port field into address and support change…
543c99c 
… the address and the port

The changes include:
* Replace the Port field name to Address
* We should support the formats Host:Port, IP:Port and Port (defaulting to 127.0.0.1)
* Adapt the app backend to parse the address correctly.

- Closes: build-trust#5685
0x61nas added a commit to anas-contribs/ockam that referenced this issue Sep 6, 2023
@0x61nas
feat(rust): rename the port field into address and support change the…
5c5726a 
… address and the port

The changes include:
* Replace the Port field name to Address
* Support the formats Host:Port, IP:Port and Port (defaulting to 127.0.0.1 aka `localhost`)
* Adapt the app back-end to parse the address correctly.

- Closes: build-trust#5685
0x61nas added a commit to anas-contribs/ockam that referenced this issue Sep 6, 2023
@0x61nas
feat(rust): rename the port field into address and support change the…
09c75c7 
… address and the port

The changes include:
* Replace the Port field name to Address
* Support the formats Host:Port, IP:Port and Port (defaulting to 127.0.0.1 aka `localhost`)
* Adapt the app back-end to parse the address correctly.

- Closes: build-trust#5685
0x61nas added a commit to anas-contribs/ockam that referenced this issue Sep 6, 2023
@0x61nas
feat(rust): rename the port field into address and support change the…
9c4a5c1 
… address and the port

The changes include:
* Replace the Port field name to Address
* Support the formats Host:Port, IP:Port and Port (defaulting to 127.0.0.1 aka `localhost`)
* Adapt the app back-end to parse the address correctly.

- Closes: build-trust#5685
0x61nas added a commit to anas-contribs/ockam that referenced this issue Sep 6, 2023
@0x61nas
feat(rust): rename the port field into address and support change the…
bb576d5 
… address and the port

The changes include:
* Replace the Port field name to Address
* Support the formats Host:Port, IP:Port and Port (defaulting to 127.0.0.1 aka `localhost`)
* Adapt the app back-end to parse the address correctly.

- Closes: build-trust#5685
0x61nas added a commit to anas-contribs/ockam that referenced this issue Sep 7, 2023
@0x61nas
feat(rust): rename the port field into address and support change the…
f72cd8e 
… address and the port

The changes include:
* Replace the Port field name to Address
* Support the formats Host:Port, IP:Port and Port (defaulting to 127.0.0.1 aka `localhost`)
* Adapt the app back-end to parse the address correctly.

- Closes: build-trust#5685
0x61nas added a commit to anas-contribs/ockam that referenced this issue Sep 7, 2023
@0x61nas
feat(rust): rename the port field into address and support change the…
78ca093 
… address and the port

The changes include:
* Replace the Port field name to Address
* Support the formats Host:Port, IP:Port and Port (defaulting to 127.0.0.1 aka `localhost`)
* Adapt the app back-end to parse the address correctly.

- Closes: build-trust#5685
0x61nas added a commit to anas-contribs/ockam that referenced this issue Sep 7, 2023
@0x61nas
feat(rust): rename the port field into address and support change the…
307f65a 
… address and the port

The changes include:
* Replace the Port field name to Address
* Support the formats Host:Port, IP:Port and Port (defaulting to 127.0.0.1 aka `localhost`)
* Adapt the app back-end to parse the address correctly.

- Closes: build-trust#5685
0x61nas added a commit to anas-contribs/ockam that referenced this issue Sep 7, 2023
@0x61nas
feat(rust): rename the port field into address and support change the…
9b931e6 
… address and the port

The changes include:
* Replace the Port field name to Address
* Support the formats Host:Port, IP:Port and Port (defaulting to 127.0.0.1 aka `localhost`)
* Adapt the app back-end to parse the address correctly.

- Closes: build-trust#5685
@adrianbenavides adrianbenavides mentioned this issue Aug 27, 2023
Closed
github-merge-queue bot pushed a commit that referenced this issue Sep 8, 2023
@0x61nas @adrianbenavides
feat(rust): rename the port field into address and support change the…
b7253f5 
… address and the port

The changes include:
* Replace the Port field name to Address
* Support the formats Host:Port, IP:Port and Port (defaulting to 127.0.0.1 aka `localhost`)
* Adapt the app back-end to parse the address correctly.

- Closes: #5685
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adrianbenavides adrianbenavides

@0x61nas 0x61nas

Labels
Component: App good first issue help wanted Implementation: Rust
Projects
None yet
Milestone
No milestone
3 participants
@etorreborre @adrianbenavides @0x61nas