feat(rust): rename the port field into address and support change the address and the port #5894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x61nas
force-pushed
the
feat/configurable-address
branch
3 times, most recently
from
f400554
to
cd1002b
Compare
0x61nas
changed the title
0x61nas
force-pushed
the
feat/configurable-address
branch
from
cd1002b
to
7adb614
Compare
There was a problem hiding this comment.
Hey @0x61nas , thank you so much for creating your first PR at Ockam! It looks pretty nice, just a small change regarding how to parse the service address 👍
Also, make sure to setup your github account so that your commits are signed. You can follow this guide or ask us if you have any question.
implementations/rust/ockam/ockam_app/src/shared_service/tcp_outlet/create.rs
Outdated
Show resolved
Hide resolved
implementations/typescript/ockam/ockam_app/src/routes/service/ServiceCreate.svelte
Outdated
Show resolved
Hide resolved
implementations/typescript/ockam/ockam_app/src/routes/service/ServiceCreate.svelte
Outdated
Show resolved
Hide resolved
0x61nas
force-pushed
the
feat/configurable-address
branch
2 times, most recently
from
543c99c
to
6bc9cb8
Compare
0x61nas
force-pushed
the
feat/configurable-address
branch
from
6bc9cb8
to
5c5726a
Compare
0x61nas
changed the title
0x61nas
force-pushed
the
feat/configurable-address
branch
3 times, most recently
from
9c4a5c1
to
bb576d5
Compare
implementations/rust/ockam/ockam_app/src/shared_service/tcp_outlet/create.rs
Outdated
Show resolved
Hide resolved
0x61nas
force-pushed
the
feat/configurable-address
branch
from
bb576d5
to
ac37a0a
Compare
0x61nas
force-pushed
the
feat/configurable-address
branch
6 times, most recently
from
d4b97e4
to
307f65a
Compare
… address and the port The changes include: * Replace the Port field name to Address * Support the formats Host:Port, IP:Port and Port (defaulting to 127.0.0.1 aka `localhost`) * Adapt the app back-end to parse the address correctly. - Closes: build-trust#5685
0x61nas
force-pushed
the
feat/configurable-address
branch
from
307f65a
to
9b931e6
Compare
adrianbenavides
approved these changes
Sep 8, 2023
There was a problem hiding this comment.
LGTM! 🚀 Thanks @0x61nas for an awesome first contribution 🥳
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for the late PR, I had to take some time to parse the project structure tree.
Current behavior
The Share a service window only allows the user to define the service port and the host address it always defaults to
127.0.0.1Proposed changes
Host:Port,IP:Portand Port (defaulting to 127.0.0.1)Checks