Add proper parsing/emitting of Windows style paths #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdSchouten
force-pushed
the
feature/implement-windows-parser-and-on-drive-letter
branch
2 times, most recently
from
ba97988
to
59ef57e
Compare
Bazel on my Mac seems to insert a couple more entries into this file.
To give better error messages for which file or directory operation fails.
EdSchouten
force-pushed
the
feature/implement-windows-parser-and-on-drive-letter
branch
5 times, most recently
from
48cf1ee
to
d606e37
Compare
EdSchouten
force-pushed
the
feature/implement-windows-parser-and-on-drive-letter
branch
from
d606e37
to
3e6ca8c
Compare
It's really annoying that these functions can return errors. Especially because functions like path.Resolve() can also fail. Let's just make it so that these functions always return a parser. We can move the null byte check into ParseScope() to achieve what we want.
This method doesn't take a pointer receiver, so mutating rp.path is pointless.
We can simply compare 'remainder' against nil. Doing this makes it more explicit that we don't need to return the remainder in the GotSymlink case.
EdSchouten
force-pushed
the
feature/implement-windows-parser-and-on-drive-letter
branch
from
3e6ca8c
to
facdefe
Compare
EdSchouten
deleted the
feature/implement-windows-parser-and-on-drive-letter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is identical to #206, but with the review comments addressed.
Fixes: #206