Skip to content

Commit

Permalink
integrate with guanlecoja-ui 1.1 (notifications)
Browse files Browse the repository at this point in the history
Signed-off-by: Pierre Tardy <pierre.tardy@intel.com>
  • Loading branch information
Pierre Tardy committed Aug 18, 2014
1 parent b5093d2 commit 0b3bb5b
Show file tree
Hide file tree
Showing 9 changed files with 11 additions and 109 deletions.
4 changes: 2 additions & 2 deletions www/base/guanlecoja/config.coffee
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ config =
# JavaScript libraries (order matters)
deps:
"guanlecoja-ui":
version: '~1.0.0'
files: 'scripts.js'
version: '~1.1.0'
files: ['vendors.js', 'scripts.js']
moment:
version: "~2.6.0"
files: 'moment.js'
Expand Down
8 changes: 4 additions & 4 deletions www/base/src/app/about/about.controller.coffee
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
class About extends Controller
constructor: ($scope, bower_configs, config, buildbotService) ->
constructor: ($scope, config, buildbotService) ->
# translate github urls to http urls for link generations
for module in bower_configs
module.http_url = module.repository?.url?.replace("git://", "http://")
#for module in bower_configs
# module.http_url = module.repository?.url?.replace("git://", "http://")
# todo should get that info from data api
$scope.config =
bbversion: "0.9.0"
Expand All @@ -11,6 +11,6 @@ class About extends Controller
projectversion: "0.0.1"
projecturl: "http://buildbot.net"
config: config
$scope.bower_configs = bower_configs
#$scope.bower_configs = bower_configs
buildbotService.all('application.spec').getList().then (specs) ->
$scope.specs = specs
16 changes: 0 additions & 16 deletions www/base/src/app/alert-panel/alert.factory.coffee

This file was deleted.

24 changes: 0 additions & 24 deletions www/base/src/app/alert-panel/alertpanel.config.coffee

This file was deleted.

25 changes: 0 additions & 25 deletions www/base/src/app/alert-panel/alertpanel.controller.coffee

This file was deleted.

7 changes: 3 additions & 4 deletions www/base/src/app/app.run.coffee
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
class RouteChangeListener extends Run
constructor: ($rootScope, $log, config, alert) ->
constructor: ($rootScope, $log, config, glNotificationService) ->
# fire an event related to the current route
$rootScope.$on '$routeChangeSuccess', (event, currentRoute, priorRoute) ->
$rootScope.$broadcast "#{currentRoute.controller}$routeChangeSuccess",
currentRoute, priorRoute
if config.on_load_warning?
setTimeout ->
alert.warning(config.on_load_warning)
console.log config.on_load_warning
, 500
glNotificationService.notify(msg:config.on_load_warning)
, 500

This file was deleted.

3 changes: 0 additions & 3 deletions www/base/src/app/common/directives/topmenu/topmenu.tpl.jade

This file was deleted.

2 changes: 2 additions & 0 deletions www/base/src/app/index.jade
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,6 @@ extends layout
block content
gl-page-with-sidebar
gl-topbar
gl-notification

This comment has been minimized.

Copy link
@benallard

benallard Oct 22, 2014

Contributor

Can we move this to a plugin ?

This comment has been minimized.

Copy link
@tardyp

tardyp Oct 22, 2014

Member

Not really with current plugin infra. Plugin can only add pages or angular directives like force scheduler parameters. We could make it configurable though

loginbar
ui-view

0 comments on commit 0b3bb5b

Please sign in to comment.