Skip to content

Commit

Permalink
test for and supply the right number of arguments to mergeRequests fu…
Browse files Browse the repository at this point in the history
…nctions
  • Loading branch information
djmitche committed Jun 26, 2011
1 parent ba9ddd5 commit de9ffe2
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion master/buildbot/process/builder.py
Original file line number Diff line number Diff line change
Expand Up @@ -808,7 +808,7 @@ def _mergeRequests(self, breq, unclaimed_requests, mergeRequests_fn):
for other_breq_object in unclaimed_request_objects:
wfd = defer.waitForDeferred(
defer.maybeDeferred(lambda :
mergeRequests_fn(breq_object, other_breq_object)))
mergeRequests_fn(self, breq_object, other_breq_object)))
yield wfd
if wfd.getResult():
merged_request_objects.append(other_breq_object)
Expand Down
2 changes: 1 addition & 1 deletion master/buildbot/test/unit/test_process_builder.py
Original file line number Diff line number Diff line change
Expand Up @@ -489,7 +489,7 @@ def test_mergeRequests(self):
yield wfd
brdicts = wfd.getResult()

def mergeRequests_fn(breq, other):
def mergeRequests_fn(builder, breq, other):
# merge evens with evens, odds with odds
return breq.id % 2 == other.id % 2

Expand Down

0 comments on commit de9ffe2

Please sign in to comment.