Skip to content

Commit

Permalink
Fix Git failures when master-side Gerrit step used
Browse files Browse the repository at this point in the history
The Git step fetches from the wrong branch when being notified by
Gerrit 'ref-updated' events. In that case, branch=None is passed to
Git.startVC(...), hence the resulting git-fetch call tries to fetch HEAD
instead of the desired branch.

This was likely a typo from the original author.
  • Loading branch information
krf committed Nov 6, 2013
1 parent 1b7b6df commit fa6aeee
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion master/buildbot/steps/source/gerrit.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,4 +36,4 @@ def startVC(self, branch, revision, patch):
pass

branch = gerrit_branch or branch
super(Gerrit, self).startVC(gerrit_branch, revision, patch)
super(Gerrit, self).startVC(branch, revision, patch)

0 comments on commit fa6aeee

Please sign in to comment.