Grid view tag filtering bug

[rajgoesout]

Builders with selected tags are highlighted, but all the builders are displayed on the grid.

Error: "branch" is read-only
refresh@http://localhost:8010/grid_view/scripts.js:676:5
toggleTag@http://localhost:8010/grid_view/scripts.js:667:17
fn@http://localhost:8010/scripts.js?_1559194180589 line 40425 > Function:4:346
expensiveCheckFn@http://localhost:8010/scripts.js?_1559194180589:41438:18
callback@http://localhost:8010/scripts.js?_1559194180589:50965:17
$eval@http://localhost:8010/scripts.js?_1559194180589:43182:28
$apply@http://localhost:8010/scripts.js?_1559194180589:43282:25
ngEventHandler/<@http://localhost:8010/scripts.js?_1559194180589:50970:23
dispatch@http://localhost:8010/scripts.js?_1559194180589:149296:27
add/elemData.handle@http://localhost:8010/scripts.js?_1559194180589:149103:28

[rjarry]

I have the same problem, I have a more exploitable backtrace:

angular.js:15567 TypeError: Cannot assign to read only property 'branch' of object '#<Object>'
    at Grid.refresh (grid.controller.js:258)
    at Grid.changeResult (grid.controller.js:239)
    at fn (eval at compile (angular.js:16418), <anonymous>:4:255)
    at l.$eval (angular.js:19393)
    at angular.js:27827
    at Object.<anonymous> (angular.js:30812)
    at k (angular.js:387)
    at Object.$$writeModelToScope (angular.js:30810)
    at o (angular.js:30803)
    at angular.js:30797

The problem occurs here: https://github.com/buildbot/buildbot/blob/v2.4.1/www/grid_view/src/module/grid.controller.js#L258