Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticket #2643 [nine] Remove the is_dir attribute of changes #1054

Merged
merged 1 commit into from
Jan 21, 2014

Conversation

delanne
Copy link
Contributor

@delanne delanne commented Jan 20, 2014

PR for the trac ticket http://trac.buildbot.net/ticket/2643

@djmitche
Copy link
Member

Sorry for the delay - I got tied up in #1045 and #1055 .. those are worth the time though.


if is_dir is not None:
log.msg("WARNING: change source is providing deprecated "
"value is_dir (ignored)")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@djmitche djmitche merged commit 7535af4 into buildbot:nine Jan 21, 2014
@djmitche
Copy link
Member

And behold, it was perfect in every way.

@delanne delanne deleted the 9/trac2643 branch September 24, 2014 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants