Refresh the First-run instructions. #1314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
benallard
commented
Nov 1, 2014
benallard
commented
- Move to pip
- Don't activate the virtualenv (IMO not necessary)
- Put less emphasis on docker.
- Remove the use of tail
- Refresh the logs (2011 and 2009 !)
- Explain a bit more what the commands are for.
- Move to pip - Don't activate the virtualenv (IMO not necessary) - Put less emphasis on docker. - Remove the use of tail - Refresh the logs (2011 and 2009 !) - Explain a bit more what the commands are for.
|
As I started rephrasing the part about docker, I realised that the rest also was in the need for a refreshment. |
| @@ -14,148 +14,113 @@ In this tutorial no configuration or code changes are done. | |||
|
|
|||
| This tutorial assumes that you are running on Unix, but might be adaptable easily to Windows. | |||
|
|
|||
| For the :ref:`fastest way through in Linux <first-run-docker-label>`, you can use Docker, the Linux container engine. Docker automates all the deployment steps for you. | |||
| Thank to virtualenv_, installing buildbot in a standalone environment is very easy. For those more familiar with Docker_, there also exists a :ref:`docker version of these instructions <first-run-docker-label>`. Be warned that Docker can be tricky to get working correctly. | |||
|
|
|||
There was a problem hiding this comment.
One sentence per line, please
"Thank_s_ to.."
It might be better to move the Docker warning to the Docker page -- it sounds a little scary here in the second paragraph of the Buildbot tutorial.
|
Sorry for the detailed edits - this is overall a good improvement and update.. thanks! |
|
No problems at all ! I wish I had this level of review on my docs more often !!! |
- One sentence per line - Restored the ``code-block``s - language fix
|
PR updated, we still need to agree on the name for the virtualenv (if that need to change) |
|
Let's split the virtualenvs, I agree that it's better (nearer to the reality) ! |
|
Now updated with two virtualenvs. |
|
👍 |
sa2ajj
pushed a commit
that referenced
this pull request
Nov 3, 2014
Refresh the First-run instructions
|
Great update! Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.