[nine] StringDownload: fix an exception that happens if the transfer fails #1672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simple 'None' check is required. Adding new unit test that does fail without the patch.
| @@ -563,7 +615,6 @@ def testBasic(self): | |||
| ss.asDict.return_value = dict(revision="12345") | |||
| s.build.getSourceStamp.return_value = ss | |||
|
|
|||
| s.step_status = Mock() | |||
There was a problem hiding this comment.
This wasnt really part of this patch, but had noticed that "step_status" was still being referenced here, so I removed it. Tests still pass.
|
👍 |
sa2ajj
pushed a commit
that referenced
this pull request
May 17, 2015
…nine [nine] StringDownload: fix an exception that happens if the transfer fails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a port to Nine (where I should have done it first) of GH-1657.
Simple 'None' check is required.
Adding new unit test that does fail without the patch.