rename "slavesrc" to "workersrc" in buildbot-worker's uploadFile and uploadDirectory commands #2239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 85.11%@@ master #2239 diff @@
==========================================
Files 334 334
Lines 32098 32119 +21
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 27316 27337 +21
Misses 4782 4782
Partials 0 0
|
|
looks good! waiting a bit for other to review |
…uploadDirectory commands This is expected backward incompatible master/worker API change.
rutsky
force-pushed
the
upload_rename_slavesrc
branch
from
3ed621a
to
db79844
Compare
|
Rebased, temporary workarounds removed --- ready for merge (if Travis will be happy). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is expected backward incompatible master/worker API change.
Release notes are in WIP branch: https://github.com/rutsky/buildbot/blob/simple-e2e-test/master/docs/index.rst
I'll cherry-pick them as soon as dependent pull requests (#2234, #2237) will be merged.