New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename "slavedest" to "workerdest" in buildbot-worker's downloadFile command #2244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 84.28%
@@ master #2244 diff @@
==========================================
Files 359 359
Lines 34410 34422 +12
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 29000 29012 +12
Misses 5410 5410
Partials 0 0
|
rutsky
changed the title
rename "slavesrc" to "workersrc" in buildbot-worker's uploadFile and uploadDirectory commands
rename "slavedest" to "workerdest" in buildbot-worker's downloadFile command
May 30, 2016
Looks like I missed some changes in tests — need to update tests. |
Tests coverage should be fixed now. |
rutsky
force-pushed
the
downloadFile_rename_slavedest
branch
from
June 8, 2016 01:44
880a444
to
b08f2cb
Compare
Rebased, temporary workarounds removed. Still based on PR #2239, but it's ok to merge both. |
needs rebase |
…command This is expected backward incompatible master/worker API change.
incremental_patch test doesn't use changed downloadFile().
Worker 2.16 uses `slavedest` instead `workerdest`.
rutsky
force-pushed
the
downloadFile_rename_slavedest
branch
from
June 20, 2016 13:07
b08f2cb
to
93ef3f1
Compare
Rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is expected backward incompatible master/worker API change.
Based on PR #2239.
Release notes are in WIP branch: https://github.com/rutsky/buildbot/blob/simple-e2e-test/master/docs/index.rst
I'll cherry-pick them when dependent PRs will be merged.