Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename "slavedest" to "workerdest" in buildbot-worker's downloadFile command #2244

Merged
merged 4 commits into from Jun 23, 2016

Conversation

rutsky
Copy link
Member

@rutsky rutsky commented May 30, 2016

This is expected backward incompatible master/worker API change.

Based on PR #2239.

Release notes are in WIP branch: https://github.com/rutsky/buildbot/blob/simple-e2e-test/master/docs/index.rst
I'll cherry-pick them when dependent PRs will be merged.

@codecov-io
Copy link

codecov-io commented May 30, 2016

Current coverage is 84.28%

Merging #2244 into master will increase coverage by <.01%

  1. 7 files (not in diff) in ...ldbot_worker/scripts were created. more
  2. 6 files (not in diff) in ...dbot_worker/commands were created. more
  3. 11 files (not in diff) in ...rker/buildbot_worker were created. more
  4. 2 files (not in diff) in ...ster/buildbot/worker were modified. more
    • Hits +3
  5. 2 files (not in diff) in master/buildbot/db were modified. more
    • Misses +9
    • Hits +16
  6. 1 files (not in diff) in master/buildbot were modified. more
    • Hits +5
@@             master      #2244   diff @@
==========================================
  Files           359        359          
  Lines         34410      34422    +12   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          29000      29012    +12   
  Misses         5410       5410          
  Partials          0          0          

Sunburst

Powered by Codecov. Last updated by 61fe64b...93ef3f1

@rutsky rutsky changed the title rename "slavesrc" to "workersrc" in buildbot-worker's uploadFile and uploadDirectory commands rename "slavedest" to "workerdest" in buildbot-worker's downloadFile command May 30, 2016
@rutsky
Copy link
Member Author

rutsky commented May 30, 2016

Looks like I missed some changes in tests — need to update tests.

@rutsky
Copy link
Member Author

rutsky commented Jun 5, 2016

Tests coverage should be fixed now.

@rutsky rutsky force-pushed the downloadFile_rename_slavedest branch from 880a444 to b08f2cb Compare June 8, 2016 01:44
@rutsky
Copy link
Member Author

rutsky commented Jun 8, 2016

Rebased, temporary workarounds removed. Still based on PR #2239, but it's ok to merge both.

@tardyp
Copy link
Member

tardyp commented Jun 15, 2016

needs rebase

…command

This is expected backward incompatible master/worker API change.
incremental_patch test doesn't use changed downloadFile().
Worker 2.16 uses `slavedest` instead `workerdest`.
@rutsky rutsky force-pushed the downloadFile_rename_slavedest branch from b08f2cb to 93ef3f1 Compare June 20, 2016 13:07
@rutsky
Copy link
Member Author

rutsky commented Jun 20, 2016

Rebased

@tardyp tardyp closed this Jun 20, 2016
@tardyp tardyp reopened this Jun 20, 2016
@tardyp tardyp merged commit 6968fae into buildbot:master Jun 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants