BuildbotServiceManager: support reconfiguration for legacy services #2605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a lot of legacy services (Schedulers and ChangeSources) which do not support reconfigService, and are not reconfigurable. Porting everything to reconfigurable is a lot of work, mainly in the unit tests as they must properly construct a service hierarchy. Rewritting everything makes few sense, so we add a method so that the BuildbotServiceManager detects when the service do not support reconfiguration and then just swap the old service with the new service, instead of reconfigure. This is racy and not optimal, but much better than not reconfiguring (without warning). Signed-off-by: Pierre Tardy <tardyp@gmail.com>
tardyp
force-pushed
the
changesources
branch
2 times, most recently
from
325c465
to
7c38da9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a lot of legacy services (Schedulers and ChangeSources)
which do not support reconfigService, and are not reconfigurable.
Porting everything to reconfigurable is a lot of work, mainly in the unit tests
as they must properly construct a service hierarchy.
Rewritting everything makes few sense, so we add a method so that the
BuildbotServiceManager detects when the service do not support reconfiguration
and then just swap the old service with the new service, instead of reconfigure.
This is racy and not optimal, but much better than not reconfiguring (without warning).
Contributor Checklist: