Add settings web testing / change the values and check it after web b… #2721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tardyp
requested changes
Feb 3, 2017
smokes/e2e/settings.scenarios.coffee
Outdated
| settings.changeScallingFactor(scallingVar) | ||
| waterfall.go() | ||
| settings.goSettings().then () -> | ||
| browser.sleep(1000) |
There was a problem hiding this comment.
why a sleep? I dont thing there is a need.
I dont think the then() is needed either
smokes/e2e/settings.scenarios.coffee
Outdated
| settings.goSettings() | ||
| settings.changeColumnWidth(columnVar) | ||
| waterfall.go() | ||
| settings.goSettings().then () -> |
Codecov Report
@@ Coverage Diff @@
## master #2721 +/- ##
=======================================
Coverage 87.35% 87.35%
=======================================
Files 310 310
Lines 32837 32837
=======================================
Hits 28684 28684
Misses 4153 4153Continue to review full report at Codecov.
|
|
@desurd Looks like you forgot to fix that one |
…rowsing Signed-off-by: desurd <david.desurmont@gmail.com>
tardyp
approved these changes
Feb 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rowsing
Signed-off-by: desurd david.desurmont@gmail.com