Add instance id to build properties #2762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dinatale2, thanks for your PR! By analyzing the history of the files in this pull request, we identified @stell-aelsabbahy, @davebx and @tardyp to be potential reviewers. |
|
If we do this for EC2, then I think we should do this for the rest of the latent workers. |
|
looks good, but please watch out the contributor checklist.
|
dinatale2
force-pushed
the
instance-id-upstream
branch
from
9f2c964
to
377e14e
Compare
Codecov Report@@ Coverage Diff @@
## master #2762 +/- ##
==========================================
+ Coverage 87.32% 87.32% +<.01%
==========================================
Files 305 305
Lines 32582 32583 +1
==========================================
+ Hits 28451 28452 +1
Misses 4131 4131
Continue to review full report at Codecov.
|
Add instance id to a workers properties. This will enable use of the AWS toolkit. Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
dinatale2
force-pushed
the
instance-id-upstream
branch
from
377e14e
to
b0da4c9
Compare
tardyp
approved these changes
Feb 10, 2017
This was referenced Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor Checklist:
Note sure if this is a good idea or not. But, having the instance id is handy when attempting to run various ec2 related tools. Any thoughts?