Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github: Fix error handling in case of bad interpolaters #4907

Merged
merged 1 commit into from Jul 25, 2019
Merged

github: Fix error handling in case of bad interpolaters #4907

merged 1 commit into from Jul 25, 2019

Conversation

tardyp
Copy link
Member

@tardyp tardyp commented Jul 22, 2019 •
edited

Fix: #4898

Contributor Checklist:

  • I have updated the unit tests
  • I have created a file in the master/buildbot/newsfragments directory (and read the README.txt in that directory)
  • I have updated the appropriate documentation

@codecov
Copy link

codecov bot commented Jul 22, 2019 •
edited

Codecov Report

Merging #4907 into master will increase coverage by 0.21%.
The diff coverage is 20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4907      +/-   ##
==========================================
+ Coverage   88.82%   89.03%   +0.21%     
==========================================
  Files         330      329       -1     
  Lines       34082    33753     -329     
==========================================
- Hits        30272    30052     -220     
+ Misses       3810     3701     -109
Impacted Files Coverage Δ
master/buildbot/reporters/github.py 88.77% <20%> (-2.72%) ⬇️
master/buildbot/scripts/cleanupdb.py 86.53% <0%> (-13.47%) ⬇️
master/buildbot/worker_transition.py 44.44% <0%> (-8.89%) ⬇️
master/buildbot/db/connector.py 98.75% <0%> (-1.25%) ⬇️
master/buildbot/worker/ec2.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce20a96...b7c8e76. Read the comment docs.

@p12tic p12tic merged commit a862079 into buildbot:master Jul 25, 2019
@EndrII
Copy link

EndrII commented Jul 26, 2019

thanks

angeloudy pushed a commit to angeloudy/buildbot that referenced this pull request Aug 13, 2019
Squashed commit of the following:
701485f 
commit b381c87
Merge: 2289275 baf8b9a
Author: Tao ZHOU <angeloudy@gmail.com>
Date:   Thu Aug 8 10:13:30 2019 +1000

    Merge branch 'master' into support-glob-recursive

commit baf8b9a
Merge: c54138c e60b114
Author: Pierre Tardy <tardyp@gmail.com>
Date:   Mon Aug 5 23:14:34 2019 +0200

    Merge pull request buildbot#4941 from PhilippSelenium/PhilippSelenium-patch-ubuntu18.04

    Philipp selenium patch ubuntu18.04

commit c54138c
Merge: da38451 3b4a0cc
Author: Pierre Tardy <tardyp@gmail.com>
Date:   Mon Aug 5 23:13:37 2019 +0200

    Merge pull request buildbot#4927 from rajdeepbharati/b4c

    Add webpage to display all builds for a revision

commit e60b114
Author: PhilippSelenium <31542906+PhilippSelenium@users.noreply.github.com>
Date:   Mon Aug 5 15:20:32 2019 +0200

    Added newsfragment

commit e7ba334
Author: PhilippSelenium <31542906+PhilippSelenium@users.noreply.github.com>
Date:   Mon Aug 5 15:12:34 2019 +0200

    Buildbot worker dockerfile from ubuntu 18.04

    1. dumb-init can be installed from apt
    2. pip can be installed from apt

commit 3b4a0cc
Author: Rajdeep Bharati <rajdeep@macports.org>
Date:   Mon Aug 5 16:30:15 2019 +0530

    Create new changebuilds page

    Displays all builds for the selected change.

commit da38451
Merge: 7e3559f ca880c5
Author: Pierre Tardy <tardyp@gmail.com>
Date:   Sat Aug 3 14:16:22 2019 +0200

    Merge pull request buildbot#4934 from kravietz/bitbucketcloud_update

    Fix buildbot#4873 per latest Bitbucket API documentation

commit ca880c5
Author: Pawel Krawczyk <616047+kravietz@users.noreply.github.com>
Date:   Sat Aug 3 12:22:25 2019 +0100

    Remove one more occurence of `username` field

commit 5bc59ac
Author: Pawel Krawczyk <616047+kravietz@users.noreply.github.com>
Date:   Sat Aug 3 10:31:54 2019 +0100

    Simplify project name retrieval

commit 3285cfa
Author: Pawel Krawczyk <616047+kravietz@users.noreply.github.com>
Date:   Fri Aug 2 10:53:50 2019 +0100

    Reflect recent changes in Bitbucket Cloud API

commit fc7d39b
Author: Pawel Krawczyk <616047+kravietz@users.noreply.github.com>
Date:   Fri Aug 2 10:50:11 2019 +0100

    Add newfragment

commit 74f1040
Author: Pawel Krawczyk <616047+kravietz@users.noreply.github.com>
Date:   Fri Aug 2 10:35:33 2019 +0100

    Fix buildbot#4873 per latest Bitbucket API documentation

    * replace the username property with nickname (per the privacy changes in API)
      https://confluence.atlassian.com/bitbucket/event-payloads-740262817.html#EventPayloads-entity_user

    * per Bitbucket documentation the project property in repository is not guaranteed to be always present which was also crashing my Buildbot
      https://confluence.atlassian.com/bitbucket/event-payloads-740262817.html#EventPayloads-entity_repositoryRepository

commit 2289275
Merge: f28087b 0b1bb83
Author: angeloudy <angeloudy@yahoo.com>
Date:   Fri Aug 2 16:09:00 2019 +1000

    Merge branch 'support-glob-recursive' of https://github.com/angeloudy/buildbot into support-glob-recursive

commit f28087b
Author: angeloudy <angeloudy@yahoo.com>
Date:   Fri Aug 2 16:08:22 2019 +1000

    Update tests

commit 0b1bb83
Merge: d4cac79 7e3559f
Author: Tao ZHOU <angeloudy@gmail.com>
Date:   Fri Aug 2 15:54:20 2019 +1000

    Merge branch 'master' into support-glob-recursive

commit d4cac79
Author: angeloudy <angeloudy@yahoo.com>
Date:   Fri Aug 2 15:53:16 2019 +1000

    Add tests

commit c8f761d
Author: angeloudy <angeloudy@yahoo.com>
Date:   Fri Aug 2 15:24:41 2019 +1000

    recursive glob is only supported in python3.5+

commit 7e3559f
Merge: 14a2337 7658c96
Author: Pierre Tardy <tardyp@gmail.com>
Date:   Thu Aug 1 20:08:50 2019 +0200

    Merge pull request buildbot#4932 from tardyp/trigger_ui

    fix initial value of the pagination counter and polish pagination UI

commit 14a2337
Merge: 5a15c12 7b78ea5
Author: Pierre Tardy <tardyp@gmail.com>
Date:   Thu Aug 1 20:08:22 2019 +0200

    Merge pull request buildbot#4904 from rajdeepbharati/b4c-api-bug

    Handle exception in BuildsEndpoint

commit 5a15c12
Merge: ad33ac8 1e65e53
Author: Pierre Tardy <tardyp@gmail.com>
Date:   Thu Aug 1 17:53:40 2019 +0200

    Merge pull request buildbot#4901 from rajdeepbharati/waterfall-tags

    Allow filtering by tags in waterfall view

commit 1e65e53
Author: Rajdeep Bharati <rajdeep@macports.org>
Date:   Thu Aug 1 20:11:17 2019 +0530

    Minor refactoring

commit 7658c96
Author: Pierre Tardy <tardyp@gmail.com>
Date:   Thu Aug 1 14:16:30 2019 +0200

    polish pagination widget look

commit 2c9cf25
Author: Pierre Tardy <tardyp@gmail.com>
Date:   Thu Aug 1 14:06:44 2019 +0200

    fix initial value of the pagination counter

commit 7b78ea5
Merge: 2a00246 ad33ac8
Author: Pierre Tardy <tardyp@gmail.com>
Date:   Thu Aug 1 13:45:28 2019 +0200

    Merge branch 'master' into b4c-api-bug

commit ad33ac8
Merge: 76600a6 f649c0e
Author: Pierre Tardy <tardyp@gmail.com>
Date:   Thu Aug 1 13:32:30 2019 +0200

    Merge pull request buildbot#4920 from bertranddemiddelaer/user/bertrand/fix_multiple_sql_queries

    divide number of sql queries for getPrevSuccessfulBuild() by 100

commit 76600a6
Merge: 386d05b 039d3a1
Author: Pierre Tardy <tardyp@gmail.com>
Date:   Thu Aug 1 13:30:11 2019 +0200

    Merge pull request buildbot#4923 from muks/mock-docs-update

    Mock docs update

commit f649c0e
Author: Bertrand Demiddelaer <bertrand.demiddelaer@scality.com>
Date:   Thu Aug 1 10:06:20 2019 +0200

    cosmetics on newsfragment

commit 01f83fa
Merge: 95da954 5217cb9
Author: angeloudy <angeloudy@yahoo.com>
Date:   Thu Aug 1 11:31:56 2019 +1000

    Merge branch 'support-glob-recursive' of https://github.com/angeloudy/buildbot into support-glob-recursive

commit 95da954
Author: angeloudy <angeloudy@yahoo.com>
Date:   Thu Aug 1 11:29:24 2019 +1000

    Add newsfragment

commit fadf22a
Author: Rajdeep Bharati <rajdeep@macports.org>
Date:   Thu Aug 1 03:31:48 2019 +0530

    Rename setTagBuilders -> makeTagBuilders

commit 0245d9c
Author: Rajdeep Bharati <rajdeep@macports.org>
Date:   Tue Jul 30 20:07:25 2019 +0530

    Add e2e test for waterfall tag

commit 2a00246
Merge: 003005f 386d05b
Author: Pierre Tardy <tardyp@gmail.com>
Date:   Wed Jul 31 18:49:07 2019 +0200

    Merge branch 'master' into b4c-api-bug

commit 2af9902
Author: Pierre Tardy <tardyp@gmail.com>
Date:   Wed Jul 31 18:48:11 2019 +0200

    Update getPrevSuccessfulBuild-number-of-sql-queries.bugfix

commit 2b6debe
Merge: 6487085 386d05b
Author: Pierre Tardy <tardyp@gmail.com>
Date:   Wed Jul 31 18:47:48 2019 +0200

    Merge branch 'master' into user/bertrand/fix_multiple_sql_queries

commit 5217cb9
Merge: 6a2ac28 386d05b
Author: Pierre Tardy <tardyp@gmail.com>
Date:   Wed Jul 31 18:46:36 2019 +0200

    Merge branch 'master' into support-glob-recursive

commit 039d3a1
Merge: 24cc8cf 386d05b
Author: Pierre Tardy <tardyp@gmail.com>
Date:   Wed Jul 31 18:46:20 2019 +0200

    Merge branch 'master' into mock-docs-update

commit 386d05b
Merge: 501f1d9 056301f
Author: Pierre Tardy <tardyp@gmail.com>
Date:   Wed Jul 31 18:44:16 2019 +0200

    Merge pull request buildbot#4929 from tardyp/trigger_ui

    Trigger ui optimization for large scale triggers

commit 6487085
Author: Bertrand Demiddelaer <bertrand.demiddelaer@scality.com>
Date:   Fri Jul 26 16:03:49 2019 +0200

    added a newsfragment

commit 056301f
Author: Pierre Tardy <tardyp@gmail.com>
Date:   Tue Jul 30 14:23:51 2019 +0200

    add paging to the trigger step UI

    This will avoid big slow downs of the UI when managing huge numbers of triggered builds

commit fd46efa
Author: Pierre Tardy <tardyp@gmail.com>
Date:   Tue Jul 30 13:40:53 2019 +0200

    buildsummary: optimize split between buildrequest URL other URLs

    We only compute those when the step data is changing.

commit 501f1d9
Merge: 8019cfc eb6eff5
Author: Pierre Tardy <tardyp@gmail.com>
Date:   Tue Jul 30 18:02:08 2019 +0200

    Merge pull request buildbot#4931 from rajdeepbharati/pyparsing

    Update pyparsing from 2.4.1 to 2.4.2

commit eb6eff5
Author: Rajdeep Bharati <rajdeep@macports.org>
Date:   Tue Jul 30 21:04:23 2019 +0530

    Update pyparsing from 2.4.1 to 2.4.2

commit 24cc8cf
Author: Mukund Sivaraman <muks@akira.org>
Date:   Mon Jul 29 14:07:01 2019 +0530

    Add docs on how to get the build master to monitor mock steps output

commit 28db079
Author: Mukund Sivaraman <muks@akira.org>
Date:   Mon Jul 29 14:06:31 2019 +0530

    Fix typo in doc

commit 6a2ac28
Author: angeloudy <angeloudy@yahoo.com>
Date:   Mon Jul 29 16:33:24 2019 +1000

    Support '**' in glob

commit 8019cfc
Merge: d41e911 a8b6694
Author: Povilas Kanapickas <povilas@radix.lt>
Date:   Sat Jul 27 20:41:02 2019 +0300

    Merge pull request buildbot#4917 from rajdeepbharati/favicon

    Configure webpack to load images.

commit 003005f
Author: Pierre Tardy <tardyp@gmail.com>
Date:   Fri Jul 26 16:00:53 2019 +0200

    Update builds.py

commit 4c2ac16
Author: Bertrand Demiddelaer <bertrand.demiddelaer@scality.com>
Date:   Fri Jul 26 15:59:03 2019 +0200

    divide the number of sql queries triggered by getPrevSuccessfulBuild() by up to 100

commit d41e911
Merge: 7e50f43 9c4d25c
Author: Pierre Tardy <tardyp@gmail.com>
Date:   Fri Jul 26 15:56:48 2019 +0200

    Merge pull request buildbot#4909 from esc/docs/fix_typo

    fix typo

commit 7e50f43
Merge: a862079 5213c39
Author: Pierre Tardy <tardyp@gmail.com>
Date:   Fri Jul 26 15:56:18 2019 +0200

    Merge pull request buildbot#4910 from buildbot/pyup-scheduled-update-2019-07-22

    Scheduled weekly dependency update for week 29

commit a862079
Merge: ce20a96 b7c8e76
Author: Povilas Kanapickas <povilas@radix.lt>
Date:   Thu Jul 25 21:14:58 2019 +0300

    Merge pull request buildbot#4907 from tardyp/github_reporter_erroring

    github: Fix error handling in case of bad interpolaters

commit a8b6694
Author: Rajdeep Bharati <rajdeep@macports.org>
Date:   Wed Jul 24 22:06:40 2019 +0530

    Configure webpack to load images.

    Import img files in app.module.js and configure webpack.

    Fixes buildbot#4880

commit 7531fbd
Author: Rajdeep Bharati <rajdeep@macports.org>
Date:   Wed Jul 24 19:13:34 2019 +0530

    Allow changing tags from url without reloading

    watch for $locationChangeSuccess

commit 5213c39
Author: pyup-bot <github-bot@pyup.io>
Date:   Mon Jul 22 16:05:25 2019 +0200

    Update werkzeug from 0.15.4 to 0.15.5

commit 45a2e80
Author: pyup-bot <github-bot@pyup.io>
Date:   Mon Jul 22 16:05:24 2019 +0200

    Update sqlalchemy from 1.3.5 to 1.3.6

commit f4e91de
Author: pyup-bot <github-bot@pyup.io>
Date:   Mon Jul 22 16:05:23 2019 +0200

    Update pyparsing from 2.4.0 to 2.4.1

commit 78505d6
Author: pyup-bot <github-bot@pyup.io>
Date:   Mon Jul 22 16:05:22 2019 +0200

    Update pillow from 6.0.0 to 6.1.0

commit 83ae089
Author: pyup-bot <github-bot@pyup.io>
Date:   Mon Jul 22 16:05:21 2019 +0200

    Update pbr from 5.3.1 to 5.4.1

commit a9ef7be
Author: pyup-bot <github-bot@pyup.io>
Date:   Mon Jul 22 16:05:20 2019 +0200

    Update pbr from 5.3.1 to 5.4.1

commit 68c0c47
Author: pyup-bot <github-bot@pyup.io>
Date:   Mon Jul 22 16:05:19 2019 +0200

    Update moto from 1.3.9 to 1.3.13

commit 2a44b5b
Author: pyup-bot <github-bot@pyup.io>
Date:   Mon Jul 22 16:05:17 2019 +0200

    Update flake8 from 3.7.7 to 3.7.8

commit 955df86
Author: pyup-bot <github-bot@pyup.io>
Date:   Mon Jul 22 16:05:16 2019 +0200

    Update docutils from 0.14 to 0.15

commit 1e13ef9
Author: pyup-bot <github-bot@pyup.io>
Date:   Mon Jul 22 16:05:15 2019 +0200

    Update botocore from 1.12.180 to 1.12.192

commit b48d5db
Author: pyup-bot <github-bot@pyup.io>
Date:   Mon Jul 22 16:05:14 2019 +0200

    Update boto3 from 1.9.180 to 1.9.192

commit d10117b
Author: pyup-bot <github-bot@pyup.io>
Date:   Mon Jul 22 16:05:13 2019 +0200

    Update autobahn from 19.6.2 to 19.7.1

commit 6b775d7
Author: Rajdeep Bharati <rajdeep@macports.org>
Date:   Sun Jul 21 18:45:24 2019 +0530

    Handle exception in BuildsEndpoint

    Check whether `filters` variable is defined.

    Fixes buildbot#4903

commit 72cc587
Author: Rajdeep Bharati <rajdeep@macports.org>
Date:   Mon Jul 22 18:39:50 2019 +0530

    Restructure code related to waterfall tags

    Use better variable/function names, follow best practices.

commit 9c4d25c
Author: Valentin Haenel <vhaenel@anaconda.com>
Date:   Mon Jul 22 15:04:52 2019 +0200

    fix typo

commit b7c8e76
Author: Pierre Tardy <tardyp@gmail.com>
Date:   Mon Jul 22 13:31:24 2019 +0200

    github: Fix error handling in case of bad interpolaters

commit 7cc1cb9
Author: Rajdeep Bharati <rajdeep@macports.org>
Date:   Sat Jul 20 20:41:03 2019 +0530

    Allow filtering by tags in waterfall view

    Closes buildbot#3471

commit ce20a96
Merge: 3a084f7 3fb462e
Author: Povilas Kanapickas <povilas@radix.lt>
Date:   Sun Jul 21 12:37:37 2019 +0300

    Merge pull request buildbot#4902 from rajdeepbharati/redundant-fn

    Remove redundant function getAllTags in builders.controller.js

commit 3fb462e
Author: Rajdeep Bharati <rajdeep@macports.org>
Date:   Sat Jul 20 23:09:37 2019 +0530

    Remove redundant function getAllTags in builders.controller.js

    Closes buildbot#4900

commit 3a084f7
Merge: 8846ca9 9233f4c
Author: Pierre Tardy <tardyp@gmail.com>
Date:   Thu Jul 18 09:58:11 2019 +0200

    Merge pull request buildbot#4891 from D4ryus/master

    GerritStatusPush: Accept wantSteps

commit 8846ca9
Merge: d6f8f29 a8ac2a8
Author: Pierre Tardy <tardyp@gmail.com>
Date:   Thu Jul 18 09:57:38 2019 +0200

    Merge pull request buildbot#4872 from buildbot/pyup-scheduled-update-2019-07-01

    Scheduled weekly dependency update for week 26

commit d6f8f29
Merge: 2efbcb6 d941c7d
Author: Pierre Tardy <tardyp@gmail.com>
Date:   Thu Jul 18 09:57:19 2019 +0200

    Merge pull request buildbot#4892 from rajdeepbharati/buildsforchange

    Get all builds corresponding to a change

commit d941c7d
Author: Rajdeep Bharati <rajdeep@macports.org>
Date:   Wed Jul 17 20:54:30 2019 +0530

    Reuse code

commit 66f0f5e
Author: Rajdeep Bharati <rajdeep@macports.org>
Date:   Wed Jul 17 16:33:33 2019 +0530

    Add buildDict to spelling_wordlist

commit ab27672
Author: Rajdeep Bharati <rajdeep@macports.org>
Date:   Wed Jul 17 16:19:23 2019 +0530

    Add fakedb test for getBuildsForChange

commit 2efbcb6
Merge: 41d2feb 3cdf67c
Author: Povilas Kanapickas <povilas@radix.lt>
Date:   Tue Jul 16 23:50:36 2019 +0300

    Merge pull request buildbot#4893 from angeloudy/master

    Increase performance of deleteOldLogChunks

commit 40f9501
Author: Rajdeep Bharati <rajdeep@macports.org>
Date:   Tue Jul 16 21:03:29 2019 +0530

    Add tests for getBuildsForChange

commit f517230
Author: Rajdeep Bharati <rajdeep@macports.org>
Date:   Tue Jul 16 20:54:33 2019 +0530

    Add builds for change route in data API

commit 3171e87
Author: Rajdeep Bharati <rajdeep@macports.org>
Date:   Tue Jul 16 20:30:56 2019 +0530

    Add docs for getBuildsForChange

commit c7829dc
Author: Rajdeep Bharati <rajdeep@macports.org>
Date:   Mon Jul 15 22:59:11 2019 +0530

    Add getBuildsForChange method

    This will enable getting all builds corresponding to a change.

commit 9233f4c
Author: d4ryus <d4ryus@teknik.io>
Date:   Fri Jul 12 13:53:24 2019 +0200

    GerritStatusPush: Accept wantSteps

    Setting wantSteps=True on GerritStatusPush has no effect since it wont
    get passed to getDetailForBuilds. Change this by passing down wantSteps
    to getDetailsForBuilds in getBuildDetails.

commit a8ac2a8
Author: pyup-bot <github-bot@pyup.io>
Date:   Mon Jul 1 19:59:43 2019 +0200

    Update pg8000 from 1.13.1 to 1.13.2

commit 59fd4ab
Author: pyup-bot <github-bot@pyup.io>
Date:   Mon Jul 1 19:59:42 2019 +0200

    Update snowballstemmer from 1.2.1 to 1.9.0

commit dd09f51
Author: pyup-bot <github-bot@pyup.io>
Date:   Mon Jul 1 19:59:41 2019 +0200

    Update pathlib2 from 2.3.3 to 2.3.4

commit 2284f44
Author: pyup-bot <github-bot@pyup.io>
Date:   Mon Jul 1 19:59:40 2019 +0200

    Update moto from 1.3.8 to 1.3.9

commit 69ac67f
Author: pyup-bot <github-bot@pyup.io>
Date:   Mon Jul 1 19:59:39 2019 +0200

    Update isort from 4.3.20 to 4.3.21

commit ee11ab1
Author: pyup-bot <github-bot@pyup.io>
Date:   Mon Jul 1 19:59:38 2019 +0200

    Update botocore from 1.12.174 to 1.12.180

commit c2371ed
Author: pyup-bot <github-bot@pyup.io>
Date:   Mon Jul 1 19:59:37 2019 +0200

    Update boto3 from 1.9.174 to 1.9.180
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p12tic p12tic p12tic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to use GitHubCommentPush in BuildBot?
3 participants
@tardyp @EndrII @p12tic