WIP: Follow startup log using a stdout logger. #583
Conversation
| @@ -51,10 +51,15 @@ def run(self, basedir, quiet): | |||
| self.sent_signal = False | |||
| reactor.callLater(0.2, self.sighup) | |||
|
|
|||
| lw = LogWatcher(os.path.join(basedir, "twistd.log")) | |||
| lw = LogWatcher() | |||
| self.process = reactor.spawnProcess(lw.pp, "/usr/bin/tail", | |||
There was a problem hiding this comment.
I'll admit this has been in the codebase forever and hasn't caused any problems, but I cringe at shelling out to 'tail' instead of implementing this natively.
There was a problem hiding this comment.
One thing at at time. ;)
|
Untested, but this looks great. If there's a requirement to put |
|
This could certainly use more tests, but |
|
Looks ok to me, FWIW :) |
|
Looks fine to me, too. djmitche@pull583 moves You may want to fold http://trac.buildbot.net/ticket/2405 in here, too? |
|
@tomprince - want to get this merged? |
|
Except, that still loads packages. I think the correct thing to do, is simply say that this is an incompatible change. |
|
Works for me.. |
* Api: Improve remote api unit tests
|
@tomprince - do you want to land this for 0.8.9? |
ghost
assigned
|
This needs to be updated to merge, but is otherwise ready to go, i think. |
|
Closing for now, but the code is here! |
No description provided.