Replace flake8/pep8 with ruff #7436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
commented
Feb 15, 2024
| select = ["I"] | ||
| select = ["W", "E", "F", "I"] | ||
| ignore = [ | ||
| "E711", # comparison to None should be 'if cond is None:' |
There was a problem hiding this comment.
Turns out a lot of former disabled checks are not in ruff or do not need to be ignored.
Mic92
commented
Feb 15, 2024
|
|
||
| status "merging against first commit after autopep8 and take our version when there are conflicts" | ||
| git merge $POSTPEP8 | ||
| # autopep8 takes 1h30 to run on the whole codebase, so let git resolve the obvious merge conflicts. |
There was a problem hiding this comment.
Current ruff is faster than I can type it in the terminal. So I guess this script is no longer needed.
Ruff should be much faster so no need to have this complex script anymore
|
Rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove this paragraph
If you don't remove this paragraph from the pull request description, this means you didn't read our contributor documentation, and your patch will need more back and forth before it can be accepted!
Please have a look at our developer documentation before submitting your Pull Request.
http://docs.buildbot.net/latest/developer/quickstart.html
And especially:
http://docs.buildbot.net/latest/developer/pull-request.html
Contributor Checklist:
newsfragmentsdirectory (and read theREADME.txtin that directory)