Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaces pylint with ruff #7438

Merged
merged 3 commits into from
Jul 21, 2024
Merged

Replaces pylint with ruff #7438

merged 3 commits into from
Jul 21, 2024

Conversation

Mic92
Copy link
Contributor

@Mic92 Mic92 commented Feb 16, 2024

Depends on #7436

Contributor Checklist:

  • I have updated the unit tests
  • I have created a file in the newsfragments directory (and read the README.txt in that directory)
  • I have updated the appropriate documentation

@Mic92 Mic92 changed the title Pylint Replaces pylint with ruff Feb 16, 2024
'pep8',
# spellcheck introduced in version 1.4.0
'pylint>=1.4.0',
'pyenchant',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are loosing spell checking here. I can bring in https://crates.io/crates/typos if desired.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense.

@Mic92
Copy link
Contributor Author

Mic92 commented Feb 16, 2024

As a follow up pull request, I would investigate all those pylint ignore comments. Some of them can be dropped now.

@Mic92 Mic92 force-pushed the pylint branch 2 times, most recently from b21f437 to 2b093e0 Compare June 13, 2024 19:50
@Mic92
Copy link
Contributor Author

Mic92 commented Jun 13, 2024

Ok. Now it's actually a much easier to review PR.

.bbtravis.yml Show resolved Hide resolved
@Mic92 Mic92 force-pushed the pylint branch 2 times, most recently from c2aa7aa to 99fd329 Compare July 19, 2024 13:12
@Mic92
Copy link
Contributor Author

Mic92 commented Jul 19, 2024

@p12tic rebased.

@p12tic p12tic merged commit 9fc27f7 into buildbot:master Jul 21, 2024
33 of 35 checks passed
@Mic92 Mic92 deleted the pylint branch July 22, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants