Render tags on invocations and support them in invocation search + invocation trends. #3963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siggisim
approved these changes
May 12, 2023
proto/invocation.proto
Outdated
| @@ -267,6 +267,9 @@ message InvocationQuery { | |||
|
|
|||
| // The pattern for the targets built (exact match). Ex: "//..." | |||
| string pattern = 15; | |||
|
|
|||
| // A plaintext tag for the targets built (exact match). Ex: "my-cool-tag" | |||
| string tag = 16; | |||
There was a problem hiding this comment.
lame question: would it be a lot harder to support repeated tags here? or a comma separated string?
There was a problem hiding this comment.
not really, but i'm out tomorrow so you're getting it monday :P
There was a problem hiding this comment.
just kidding, love 2 write software, here it is.
jdhollen
force-pushed
the
jh/tags-invocation-search
branch
from
ed9e1dd
to
cbc68ac
Compare
siggisim
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to add tags to the executions table in clickhouse as well, will do that separately.
Related issues: N/A