scheduler_server: rm remove_stale_executors flag for good #3994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This flag has been flipped to default true in #3859. Let's remove it entirely since turning it off would cause more problems.
vadimberezniker
approved these changes
May 17, 2023
There was a problem hiding this comment.
As a general practice, we should be careful about removing flags because if they are specified via command line they will cause the application to not start at all.
In this case, I think it's very unlikely anyone is specifying this on the command line (or at all really).
|
I know of at least one customer that sets this via |
Yes, it's not an error when set via config. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flag has been flipped to default true in #3859.
Let's remove it entirely since turning it off would cause more problems.
Related issues: https://github.com/buildbuddy-io/buildbuddy-internal/pull/2278