Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial insert when registering invocation attempt doesn't need to be in a transaction #5865

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

tempoz
Copy link
Contributor

@tempoz tempoz commented Feb 8, 2024

If the initial insert fails when registering an invocation attempt, nothing is or needs to be locked, and the insert has had no effects to roll back. If the insert succeeds, however the transaction ends. Thus, it does not to be included in the transaction.

Related issues: N/A

Copy link
Contributor Author

tempoz commented Feb 8, 2024

@tempoz tempoz force-pushed the remove-transactions-surrounding-single-queries branch from 5c0c37f to 9d32875 Compare February 13, 2024 19:49
@tempoz tempoz force-pushed the no-transaction-on-initial-insert-invocation-attempt branch from 808c6d4 to 1d6758d Compare February 13, 2024 19:49
@tempoz tempoz force-pushed the remove-transactions-surrounding-single-queries branch from 9d32875 to acc3bef Compare February 16, 2024 19:18
@tempoz tempoz force-pushed the no-transaction-on-initial-insert-invocation-attempt branch from 1d6758d to b6c5994 Compare February 16, 2024 19:18
@tempoz tempoz force-pushed the remove-transactions-surrounding-single-queries branch from acc3bef to 791c8c7 Compare February 20, 2024 17:19
@tempoz tempoz force-pushed the no-transaction-on-initial-insert-invocation-attempt branch from b6c5994 to 11efa0e Compare February 20, 2024 17:19
@tempoz tempoz force-pushed the remove-transactions-surrounding-single-queries branch from 791c8c7 to adc4c3a Compare February 20, 2024 18:09
@tempoz tempoz force-pushed the no-transaction-on-initial-insert-invocation-attempt branch from 11efa0e to dba5013 Compare February 20, 2024 18:09
@tempoz tempoz force-pushed the remove-transactions-surrounding-single-queries branch from adc4c3a to 6b9b8c0 Compare February 22, 2024 23:42
@tempoz tempoz force-pushed the no-transaction-on-initial-insert-invocation-attempt branch from dba5013 to c8644f4 Compare February 22, 2024 23:42
@tempoz tempoz force-pushed the remove-transactions-surrounding-single-queries branch from 6b9b8c0 to e8a33c8 Compare February 23, 2024 20:44
@tempoz tempoz force-pushed the no-transaction-on-initial-insert-invocation-attempt branch from c8644f4 to 6614f2f Compare February 23, 2024 20:44
@tempoz tempoz closed this Feb 23, 2024
@tempoz tempoz reopened this Feb 23, 2024
@tempoz tempoz force-pushed the remove-transactions-surrounding-single-queries branch from e8a33c8 to f152c1a Compare February 23, 2024 22:36
@tempoz tempoz force-pushed the no-transaction-on-initial-insert-invocation-attempt branch from 6614f2f to 45f6c49 Compare February 23, 2024 22:36
@tempoz tempoz force-pushed the remove-transactions-surrounding-single-queries branch from f152c1a to 98d4a6f Compare February 26, 2024 22:00
@tempoz tempoz force-pushed the no-transaction-on-initial-insert-invocation-attempt branch from 45f6c49 to a4adf1f Compare February 26, 2024 22:00
Base automatically changed from remove-transactions-surrounding-single-queries to master February 26, 2024 22:50
@tempoz tempoz force-pushed the no-transaction-on-initial-insert-invocation-attempt branch from a4adf1f to 97ef725 Compare February 26, 2024 22:51
@tempoz tempoz changed the base branch from master to check-for-missing-after-execution-update February 27, 2024 19:59
@tempoz tempoz force-pushed the no-transaction-on-initial-insert-invocation-attempt branch from 97ef725 to 4b4719f Compare February 27, 2024 19:59
Base automatically changed from check-for-missing-after-execution-update to master February 27, 2024 22:41
@tempoz tempoz force-pushed the no-transaction-on-initial-insert-invocation-attempt branch from 4b4719f to 8c8cd01 Compare February 27, 2024 22:44
@tempoz tempoz requested a review from bduffany February 28, 2024 00:15
@tempoz tempoz force-pushed the no-transaction-on-initial-insert-invocation-attempt branch from 8c8cd01 to c33c04e Compare March 1, 2024 00:33
@tempoz tempoz merged commit 5fdeaa8 into master Mar 18, 2024
18 checks passed
@tempoz tempoz deleted the no-transaction-on-initial-insert-invocation-attempt branch March 18, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants