-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce telemetry insert to one query that does nothing on conflict #6003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tempoz
force-pushed
the
check-for-missing-after-execution-update
branch
from
February 26, 2024 22:51
9566b8f
to
3e55f62
Compare
tempoz
force-pushed
the
telemetry-toctou
branch
from
February 26, 2024 22:51
51ab7c1
to
9604629
Compare
tempoz
force-pushed
the
check-for-missing-after-execution-update
branch
from
February 27, 2024 19:59
3e55f62
to
7329883
Compare
tempoz
force-pushed
the
telemetry-toctou
branch
from
February 27, 2024 19:59
9604629
to
568457f
Compare
tempoz
changed the base branch from
check-for-missing-after-execution-update
to
no-transaction-on-initial-insert-invocation-attempt
February 27, 2024 19:59
tempoz
force-pushed
the
no-transaction-on-initial-insert-invocation-attempt
branch
from
February 27, 2024 22:44
4b4719f
to
8c8cd01
Compare
tempoz
force-pushed
the
telemetry-toctou
branch
from
February 27, 2024 22:44
568457f
to
d7d592a
Compare
This was referenced Feb 27, 2024
tempoz
force-pushed
the
no-transaction-on-initial-insert-invocation-attempt
branch
from
March 1, 2024 00:33
8c8cd01
to
c33c04e
Compare
This was referenced Mar 1, 2024
Base automatically changed from
no-transaction-on-initial-insert-invocation-attempt
to
master
March 18, 2024 16:29
tempoz
force-pushed
the
telemetry-toctou
branch
from
March 18, 2024 16:33
7877d83
to
d05e825
Compare
vadimberezniker
approved these changes
Mar 18, 2024
tempoz
force-pushed
the
telemetry-toctou
branch
from
March 18, 2024 18:11
d05e825
to
e71ad64
Compare
tempoz
force-pushed
the
telemetry-toctou
branch
from
March 19, 2024 14:32
e71ad64
to
e83c7a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the number of queries we issue and also fixes a time-of-check, time-of-use problem that otherwise exists.
Related issues: N/A