Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use NUKE AbsolutePath for path construction #131

Closed
wants to merge 1 commit into from
Closed

Use NUKE AbsolutePath for path construction #131

wants to merge 1 commit into from

Conversation

GeorgDangl
Copy link
Member

@GeorgDangl GeorgDangl commented Mar 7, 2023 •
edited
Loading

This PR is just a quick update for the build script that runs the CheckTestCases target. I noticed it's using System.IO.Path to construct paths, but NUKE has some built in AbsolutePath class which makes it a bit more readable in my opinion😀

@CBenghi
Copy link
Contributor

CBenghi commented Mar 7, 2023 •
edited
Loading

That's neat, @GeorgDangl.
Thanks.

@berlotti berlotti requested review from Moult and aothms March 8, 2023 22:36
@CBenghi CBenghi mentioned this pull request Mar 25, 2023
Merged
@CBenghi
Copy link
Contributor

CBenghi commented Mar 28, 2023

Hello @GeorgDangl,
I have included your suggestions in a personal branch that has been merged now.
I think you can close this PR.
Thanks,
Claudio

@GeorgDangl GeorgDangl closed this Mar 29, 2023
@GeorgDangl GeorgDangl deleted the feature/absolute-paths-in-nuke branch March 29, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aothms aothms aothms approved these changes

@Moult Moult Awaiting requested review from Moult

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GeorgDangl @CBenghi @aothms