Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UT_Alignment_12d_11 #83

Merged
merged 1 commit into from
Jan 27, 2021
Merged

UT_Alignment_12d_11 #83

merged 1 commit into from
Jan 27, 2021

Conversation

LeeGregory12d
Copy link
Contributor

IFC4.3 RC2 Unit test

An Alignment where the vertical geometry (VG) starts after and ends before, the horizontal geometry (HG)

Review requested

  • the vertical geometry starts after and ends before the horizontal geometry
    @pjanck

Instructions

Added new UT <UT_Alignment_12d_11> with supporting documentation

@LeeGregory12d
UT_Alignment_12d_11
1e259a4 
An Alignment where the vertical geometry (VG) starts after and ends before, the horizontal geometry (HG)
@pjanck pjanck added the infra depl Infrastructure Extensions Deployment content label Jan 12, 2021
@larswik larswik mentioned this pull request Jan 18, 2021
Closed
larswik
larswik reviewed Jan 18, 2021
View reviewed changes
Copy link
Contributor

@larswik larswik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I felt that a discussion was needed before approving this. See issue #95

larswik
larswik approved these changes Jan 26, 2021
View reviewed changes
Copy link
Contributor

@larswik larswik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving after issue was discussed and closed.

@larswik larswik merged commit d301bd2 into buildingSMART:master Jan 27, 2021
AlexBrad1eyCT pushed a commit to ABCon-Tech/Sample-Test-Files that referenced this pull request Feb 8, 2021
@larswik
Merge pull request buildingSMART#83 from LeeGregory12d/UT_ALignment_1…
2ba9d64 
…2d_11

UT_Alignment_12d_11

Former-commit-id: d301bd2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larswik larswik larswik approved these changes

Assignees

@jmirtsch jmirtsch

@larswik larswik

Labels
infra depl Infrastructure Extensions Deployment content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@LeeGregory12d @larswik @jmirtsch @pjanck