Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDS Rule - Floating point numbers are compared with a 1e-6 tolerance 1/4 #221

Closed
Minna26 opened this issue Nov 27, 2023 · 2 comments
Closed

IDS Rule - Floating point numbers are compared with a 1e-6 tolerance 1/4 #221

Minna26 opened this issue Nov 27, 2023 · 2 comments
Labels
documentation Improvements or additions to documentation Test cases
Milestone
1.0

Comments

@Minna26
Copy link

Minna26 commented Nov 27, 2023

Hi,

Can you please guys check this IDS Rule: Floating point numbers are compared with a 1e-6 tolerance 1/4

To me, it seems like the comparison is with 1e-4. It seems that the number is rounded to four decimals and then compared.
Can you clarify for me how this is compared?
Thank you.
@aothms
Copy link

aothms commented Nov 27, 2023

Did you see #78 (comment)? I'm not entirely sure if this has been fully decided upon.

@CBenghi CBenghi added documentation Improvements or additions to documentation Test cases labels Feb 27, 2024
@CBenghi CBenghi added this to the 1.0 milestone Feb 27, 2024
@atomczak
Copy link
Contributor

The group has reached a conclusion, and @giuseppeverduciALMA summarised it in #294. Closing this issue. If needed, please continue in #78.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation Test cases
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
4 participants
@aothms @CBenghi @atomczak @Minna26