Tolerance: Issue #78 recap #294
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomczak
added a commit
that referenced
this pull request
May 24, 2024
removed attribute and property tests using fixed 1e6 tolerance, replaced with relative precision (according to #294)
giuseppeverduciALMA
force-pushed
the
development
branch
from
0d50fd8
to
6893df1
Compare
|
By mistake, I closed this PR while synchronizing the IDS repository. Is it possible to reconnect the fork? |
berlotti
pushed a commit
that referenced
this pull request
Jun 3, 2024
* update floating point comparison tests removed attribute and property tests using fixed 1e6 tolerance, replaced with relative precision (according to #294) * remove old floating point comparison tests remove omitted tests with a fixed tolerance
|
@giuseppeverduciALMA, I added the tolerance.md file directly to development (#317) with minor changes based on the #315. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR-related commit adds a new file "tolerance.md" to the Documentation directory. This file summarizes the discussions and comments made in issues #78 and #36 regarding tolerance in IDS.