Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent rigged files from importing themselves #26

Closed
wants to merge 1 commit into from

Conversation

isochronous
Copy link
Contributor

add a check in the _getSingle method to compare a file being imported to
the file doing the importing. If they match exactly, do not import it,
as the file would be importing itself. This is an effort to fix #25 .

add a check in the _getSingle method to compare a file being imported to
the file doing the importing.  If they match exactly, do not import it,
as the file would be importing itself.
@isochronous
Copy link
Contributor Author

Actually, this isn't ready to go yet, as imported files that import their own directories still import themselves. Need to work on this a little bit more.

@isochronous
Copy link
Contributor Author

I couldn't ever really get this working properly, and I found another package (https://github.com/timrwood/includer) that did the same thing without all these problems.

@DamonOehlman
Copy link
Member

Cool thanks for the heads up on includer. I might make a mention of that here, given I pretty much always use browserify these days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent directory import from importing self
2 participants