Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add /bin/bash support #17

Merged
merged 1 commit into from
Aug 22, 2018
Merged

Add /bin/bash support #17

merged 1 commit into from
Aug 22, 2018

Conversation

toolmantim
Copy link
Contributor

@toolmantim toolmantim commented Aug 22, 2018

When we switched to bats/bats in #15 / #16 we lost support for #!/bin/bash as bats/bats doesn't include anything there, only /usr/local/bin/bash.

Many of the plugin hooks rely on it for their shebang line, so this adds it back in, along with a guard in case the workaround is no longer needed.

bats/bats doesn't include anything at /bin/bash, but many of the plugin
hooks rely on it for their shebang line. This adds it back in, along
with a guard in case the workaround is no longer needed.
@toolmantim toolmantim requested a review from lox August 22, 2018 04:57
@toolmantim toolmantim changed the title Adds /bin/bash support Add /bin/bash support Aug 22, 2018
@lox
Copy link
Contributor

lox commented Aug 22, 2018

There are plugin hooks with /usr/local/bin/bash in the shebang?! I reckon we should probably just fix them, the only time bash should live there is in BSD.

@lox
Copy link
Contributor

lox commented Aug 22, 2018

Oh. The opposite. I can't brain.

@lox
Copy link
Contributor

lox commented Aug 22, 2018

Yeah, legit. I'll chase up with upstream why it's in /usr/local/bin that seems weird.

@lox lox merged commit 4099347 into master Aug 22, 2018
@lox lox deleted the add-bin-bash-to-image branch August 22, 2018 23:15
@toolmantim
Copy link
Contributor Author

@lox 👌🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants