-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add device-level IO limit options #262
Add device-level IO limit options #262
Conversation
The Docker run options `--device-read-bps`, `--device-read-iops`, `--device-write-bps`, `--device-write-iops` can now be set.
99b394b
to
2ab416e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great implementation!
Would you mind adding tests for the options added so that we can merge it with confidence that future changes will not break it? :)
Hi @bradleyayers! Tests are still failing, are you able to take a look? Thanks! |
245ea6b
to
1b5f3e8
Compare
I've pushed a new commit… I had some trouble writing tests:
Ideally I'd be able to test and make sure it's all good before requesting a review, so apologies for the PR churn. |
1b5f3e8
to
216a54c
Compare
@toote ok I think it might be working now |
The plugin's documentation about development shows you how to do that either using the
That is a security measure on purpose :)
Any improvement is more than welcome and efforts to comply with our review is extremely appreciated ❤️ In this process we all get better :) |
The Docker run options
--device-read-bps
,--device-read-iops
,--device-write-bps
,--device-write-iops
can now be set.