Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support using default config on no path match #29

Merged
merged 7 commits into from
Oct 7, 2024
Merged

Conversation

mcncl
Copy link

@mcncl mcncl commented Oct 7, 2024

Changes

Issue #23 raises a good point of having a default config, which may be a nice addition to the plugin and allow folks to not have to cover all bases to run a config (command or trigger)

  • Supports a default config in the plugin

This can be used as either:

    ...
        - default:
            config:
              command: buildkite-agent pipeline upload other_tests.yml
    ...

or:

    ...
        - default:
            trigger: cool-pipeline
    ...
  • Added tests to cover the cases where default may be used

@mcncl mcncl marked this pull request as ready for review October 7, 2024 10:58
@mcncl mcncl requested a review from a team as a code owner October 7, 2024 10:58
Copy link

@tomowatt tomowatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mcncl
Copy link
Author

mcncl commented Oct 7, 2024

I’ll update the README in the morning @tomowatt, so will leave this unmerged for now

@mcncl mcncl merged commit d12c514 into master Oct 7, 2024
1 check passed
@mcncl mcncl deleted the bm/default_config branch October 7, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants