Fix bug where disconnect-after-idle stopped working #1004
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs a test, but it's tough to test, so going to get a fix out first. |
lox
commented
May 8, 2019
| @@ -485,7 +485,7 @@ func (a *AgentWorker) Ping() { | |||
| if a.agentConfiguration.DisconnectAfterIdleTimeout > 0 { | |||
| a.logger.Info("Job finished. Resetting idle timer...") | |||
| a.idleTimer.Reset(time.Second * time.Duration(a.agentConfiguration.DisconnectAfterIdleTimeout)) | |||
| a.idleMonitor.MarkBusy(a.agent.Name) | |||
| a.idleMonitor.MarkBusy(a.agent.UUID) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduced a bug in #985 where the wrong return param from the register API was checked and the idle monitor never detected all the agents idle.
Closes #1003.