Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Die, Bootstrap, die: Rename package bootstrap -> job #2187

Merged
merged 2 commits into from
Jul 6, 2023

Conversation

moskyb
Copy link
Contributor

@moskyb moskyb commented Jul 5, 2023

#1958, unfortunately, became ungovernable, and got too large to reasonably work on or review.

This is the start of a series of work that will do a similar thing, but break it up into smaller, easier-to-review bits of work,

This PR specifically simply renames the package bootstrap to being called job.

Open question: Should we take this chance to internalise it?

@DrJosh9000
Copy link
Contributor

I vote for internalising it. I haven't thought too deeply, but I figure there's almost no chance of someone wanting to import it (outside the agent).

Copy link
Contributor

@DrJosh9000 DrJosh9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm stamping this now because

  • I love it
  • in case you'd like to ship it and do the internal move later

Copy link
Contributor

@DrJosh9000 DrJosh9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moskyb moskyb merged commit 5217bde into main Jul 6, 2023
1 check passed
@moskyb moskyb deleted the dbd-no-more-bootstrap-package branch July 6, 2023 01:00
@DrJosh9000 DrJosh9000 added the cleanup Cleaning up code, refactoring, etc label Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Cleaning up code, refactoring, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants