Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Die, bootstrap, die: Rename Bootstrap struct (and friends) to Executor #2188

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

moskyb
Copy link
Contributor

@moskyb moskyb commented Jul 5, 2023

This PR follows from #2187

This PR: Renames the job.Bootstrap struct to job.Executor, as well as a couple of its friends. it also updates comments and associated variable names etc to be appropriately named.

@moskyb moskyb force-pushed the dbd-s-bootstrap-executor-g branch 3 times, most recently from 3e22bfb to c4c9e78 Compare July 6, 2023 01:06
Copy link
Contributor

@DrJosh9000 DrJosh9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! 🤩

Copy link
Contributor

@triarius triarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉🎉🎉🎉 Love that it's internal.

@moskyb moskyb force-pushed the dbd-s-bootstrap-executor-g branch from c4c9e78 to 63bb850 Compare July 6, 2023 04:25
@moskyb moskyb force-pushed the dbd-s-bootstrap-executor-g branch from 63bb850 to d62b4bf Compare July 6, 2023 04:49
@moskyb moskyb merged commit 30a7acb into main Jul 10, 2023
1 check passed
@moskyb moskyb deleted the dbd-s-bootstrap-executor-g branch July 10, 2023 04:28
@DrJosh9000 DrJosh9000 added the cleanup Cleaning up code, refactoring, etc label Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Cleaning up code, refactoring, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants