Quote and escape env-file values #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lox
force-pushed
the
quote-env-file-values
branch
from
4377b8d
to
1c648dd
Compare
sj26
approved these changes
Mar 14, 2018
keithpitt
approved these changes
Mar 14, 2018
@sj26 yeah, me too. |
|
Thanks for the quick work here @lox ❤️ |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow on from #680 and #643. Changes the env-file format to KEY="VALUES" with values in the quotes escaped.
This won't be compatible with docker (see the horror of moby/moby#12997), but it's the generally accepted standard (https://github.com/bkeepers/dotenv/blob/master/lib/dotenv/parser.rb and https://github.com/joho/godotenv/blob/master/godotenv.go, for example) and it's easy to parse with standard shell tools.