-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
$BUILDKITE_ENV_FILE is not documented #418
Comments
Correct, it's not documented, which means it's undocumented and you shouldn't depend on it. Here be dragons! |
Pretty much anyone who uses Docker to run builds with a custom infrastructure will want it. Otherwise I can't use my pipeline's env variables in my command steps. It should become a supported feature. |
Indeed, it's a tricky problem to solve, as Docker's env file format is basically broken. Some context at buildkite/agent#682. |
Confused what you mean. Docker's env file format being broken is independent of this issue. |
Kinda. My point is just that you can't simply jam |
I'm confused still. I'm aware of that and use the same technique the docker plugin does to do it properly. My concern is this feature is very useful but not documented. |
Noted! |
@lox so why are you hesitant to document this? |
I'm not really, if you'd submitted a PR instead of an issue I'd probably just have merged it! |
|
https://github.com/buildkite-plugins/docker-buildkite-plugin/blob/7340a5f7cfc8ffe9af8d1813e110a66d5771998c/hooks/command#L208
Its used by the docker plugin to propagate the env through correctly but doesn't seem to be documented.
The text was updated successfully, but these errors were encountered: