Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$BUILDKITE_ENV_FILE is not documented #418

Closed
nhooyr opened this issue Feb 21, 2019 · 11 comments
Closed

$BUILDKITE_ENV_FILE is not documented #418

nhooyr opened this issue Feb 21, 2019 · 11 comments

Comments

@nhooyr
Copy link

nhooyr commented Feb 21, 2019

https://github.com/buildkite-plugins/docker-buildkite-plugin/blob/7340a5f7cfc8ffe9af8d1813e110a66d5771998c/hooks/command#L208

Its used by the docker plugin to propagate the env through correctly but doesn't seem to be documented.

@lox
Copy link
Contributor

lox commented Feb 21, 2019

Correct, it's not documented, which means it's undocumented and you shouldn't depend on it. Here be dragons!

@nhooyr
Copy link
Author

nhooyr commented Feb 21, 2019

Pretty much anyone who uses Docker to run builds with a custom infrastructure will want it. Otherwise I can't use my pipeline's env variables in my command steps. It should become a supported feature.

@lox
Copy link
Contributor

lox commented Feb 21, 2019

Indeed, it's a tricky problem to solve, as Docker's env file format is basically broken. Some context at buildkite/agent#682.

@nhooyr
Copy link
Author

nhooyr commented Feb 21, 2019

Confused what you mean. Docker's env file format being broken is independent of this issue.

@lox
Copy link
Contributor

lox commented Feb 21, 2019

Kinda. My point is just that you can't simply jam BUILDKITE_ENV_FILE into docker's --env-file. Let us know how you go with it and we can potentially include some documentation in future.

@nhooyr
Copy link
Author

nhooyr commented Feb 21, 2019

I'm confused still. I'm aware of that and use the same technique the docker plugin does to do it properly. My concern is this feature is very useful but not documented.

@lox
Copy link
Contributor

lox commented Feb 21, 2019

Noted!

@nhooyr
Copy link
Author

nhooyr commented Feb 22, 2019

@lox so why are you hesitant to document this?

@lox
Copy link
Contributor

lox commented Feb 22, 2019

I'm not really, if you'd submitted a PR instead of an issue I'd probably just have merged it!

@harrietgrace
Copy link
Contributor

BUILDKITE_ENV_FILE is being added as part of #361. I'll leave this open until it's merged.

@harrietgrace harrietgrace added the in progress Issues that have a fix/update in the works label Feb 26, 2019
@harrietgrace harrietgrace removed the in progress Issues that have a fix/update in the works label Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants