Update EnableInstanceStorage to match aws-stack template in the elastic-ci-stack #2458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview URL: https://2458--bk-docs-preview.netlify.app |
mbelton-buildkite
approved these changes
Sep 5, 2023
| @@ -474,7 +474,7 @@ Parameters: | |||
|
|
|||
| EnableInstanceStorage: | |||
| Type: String | |||
| Description: Mount available NVMe Instance Storage at /mnt/ephemeral | |||
| Description: Mount available NVMe Instance Storage at /mnt/ephemeral, and use it to store docker images and containers, and the build working directory. You must ensure that the instance types have instance storage available for this to have any effect. See https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/instance-store-volumes.html | |||
There was a problem hiding this comment.
Just simplifying the sentence a little. I wanted to make the link nicer, but see that it's limited on this page.
Suggested change
| Description: Mount available NVMe Instance Storage at /mnt/ephemeral, and use it to store docker images and containers, and the build working directory. You must ensure that the instance types have instance storage available for this to have any effect. See https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/instance-store-volumes.html | |
| Description: Mount available NVMe Instance Storage at /mnt/ephemeral. Use it to store Docker images and containers, and the build's working directory. You must ensure that the instance types have instance storage available for this to have any effect. See https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/instance-store-volumes.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a forum question that raised an issue when installing the Elastic Stack 6.4.0. It was found out that the attribute
EnableInstanceStoragecan only be true if instance storage is available for the selected instance type. Our was-stack yaml template was updated in the PR, and it would be good to have this change be reflected in our docs.