Add acceptance tests for pipeline schedule #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chloeruka
force-pushed
the
acceptance-test-pipeline-schedule
branch
2 times, most recently
from
52eb16b
to
c8a7988
Compare
chloeruka
changed the title
4 tasks
This resource also lacked acceptance tests, so in order to guard against regressions we have added the following simple acceptance tests: * creating a schedule (with only the required attributes) * updating a schedule (e.g. changing its cronline) * importing a pipeline schedule This work required the addition of UUID to the pipeline schedule resource schema. The UUID is used to assemble the slug of an existing pipeline schedule.
chloeruka
force-pushed
the
acceptance-test-pipeline-schedule
branch
from
c8a7988
to
01c57c3
Compare
yob
reviewed
Feb 19, 2021
| Config: testAccPipelineScheduleConfigBasic("foo", "0 * * * *"), | ||
| Check: resource.ComposeAggregateTestCheckFunc( | ||
| // Schedules need a pipeline | ||
| testAccCheckPipelineExists("buildkite_pipeline.foobar", &resourcePipeline), |
There was a problem hiding this comment.
do we need to check the pipeline in these tests, or can we assume it works thanks to the specific tests for the pipeline resource?
There was a problem hiding this comment.
Ahh, yeah this is the rub; we don't really need to know that it exists, but if we want to validate we put a schedule on the correct pipeline later, we need a reference, so we memref it to testAccCheckPipelineExists which populates the (until now nil) value of resourcePipeline
There was a problem hiding this comment.
oooohhh, of course. I keep forgetting this methods are also about grabbing an in-memory copy of the data 👍
yob
reviewed
Feb 19, 2021
yob
approved these changes
Feb 19, 2021
yob
approved these changes
Feb 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resource also lacked acceptance tests, so in order to guard against regressions we have added the following simple acceptance tests:
This work required the addition of UUID to the pipeline schedule resource schema. The UUID is used to assemble the slug of an existing pipeline schedule.