This repository has been archived by the owner on Mar 1, 2024. It is now read-only.
simplify main api (closes #155) #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ict instead of graph + Ps
Query.id remains as optional for debugging
veej
reviewed
Mar 2, 2018
src/graph/index.d.ts
Outdated
| @@ -17,7 +17,7 @@ export type QueryArgsNoDeps< | |||
| A extends IOTSParams, | |||
| P | |||
| > = { | |||
| id: string, | |||
| id?: string, | |||
There was a problem hiding this comment.
Because it is still used as the name for the caches used in each node, and this can be helpful when debugging with DEBUG=avenger*: the logs are colored and organized by name of the cache, and the default name if not passed is just "anonymous".
We could make this more explicit and call it "cacheName" maybe?
…d nodes (not recursively all "required" nodes)
|
@veej please take a look at the last 4 commits |
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rough list of changes (all breaking!):
import { x } from 'avenger/lib/graph'->import { x } from 'avenger'import { x } from 'avenger/lib/cache/strategies'->import { x } from 'avenger'makefunction: no need to "make" anything...spread the result ofimport * as queries from 'queries'before passing it to the context providerquery,invalidate,runCommand,extract/restoreQueryCaches){ query1, ..., queryN }dictionary instead ofgraph+Psstring idsidremains as an optional prop inQuery({ id })just for debugging purposescommits should make sense if reviewed in order