This repository has been archived by the owner on Jan 31, 2020. It is now read-only.
update queries/commands api to accept references instead of string ids (closes #50 closes #49 closes #52) #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giogonzo
changed the title
giogonzo
force-pushed
the
50-update_queriescommands_api_to
branch
from
abdc649
to
0bf1e98
Compare
giogonzo
force-pushed
the
50-update_queriescommands_api_to
branch
from
482565e
to
5b7436d
Compare
veej
reviewed
Mar 15, 2018
| @@ -22,18 +28,42 @@ | |||
| }, | |||
| "homepage": "https://github.com/buildo/react-avenger#readme", | |||
| "devDependencies": { | |||
| "@types/react": "^16.0.40", | |||
src/commands.test.js
Outdated
| it('runs a command forwarding all props', async () => { | ||
| const run = jest.fn(Promise.resolve.bind(Promise)); | ||
| const doFoo = Command({ | ||
| params: { token: t.string }, |
ecamellini
approved these changes
Mar 16, 2018
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a few things:
loading#49: remove loadingtest plan
Didn't test on a project for the moment, see added tests