Skip to content
This repository has been archived by the owner on Jan 31, 2020. It is now read-only.

update queries/commands api to accept references instead of string ids #50

Closed
giogonzo opened this issue Feb 26, 2018 · 0 comments · Fixed by #51
Closed

update queries/commands api to accept references instead of string ids #50

giogonzo opened this issue Feb 26, 2018 · 0 comments · Fixed by #51
Labels

Comments

@giogonzo
Copy link
Member

requirements

superseeds #2
as per title. References are better for various reasons:

  • don't require the id key on the query description, which is currently manual & error prone
  • there's less magic & indirection: import something and use it (instead of configure something beforehand and inject it via a string id)
  • this change + remove the factory wrapping #48 make it so that queries and commands can be imported and used only where actually needed (final components) -> potentially definitions for different UI parts could end up in different, split bundles, instead of being forced in the first bundle

specs

{optional: describe technical specs to implement this feature, if not obvious}

misc

{optional: other useful info}

@nemobot nemobot added the WIP label Feb 26, 2018
giogonzo added a commit that referenced this issue Mar 16, 2018
update queries/commands api to accept references instead of string ids (closes #50 closes #49 closes #52)
@nemobot nemobot removed the WIP label Mar 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
2 participants